Skip to content

RHDHBUGS-2883 fix: missing plugins from community table due to substring filter [release-1.10] - #2511

Merged
nickboldt merged 1 commit into
redhat-developer:release-1.10from
Omar-AlJaljuli:pgrdty-quay-tables
Jul 30, 2026
Merged

nickboldt merged 1 commit into
redhat-developer:release-1.10from
Omar-AlJaljuli:pgrdty-quay-tables

Conversation

@Omar-AlJaljuli

Copy link
Copy Markdown
Collaborator

The grep -qF used to deduplicate plugins in generate_community_table() does substring matching, which causes plugins to be silently dropped when their name is a prefix of an already-processed plugin. For example, backstage-community-plugin-quay is skipped because backstage-community-plugin-quay-backend is already in the processed list and contains it as a substring. The same issue affects pagerduty-backstage-plugin (matched by pagerduty-backstage-plugin-backend).

Under LC_ALL=C, glob expansion sorts - before ., so the longer -backend variant is always processed first, making the false positive consistent and silent.

Fix: change grep -qF to grep -qxF so the dedup check requires an exact full-line match.
IMPORTANT: Do Not Merge - To be merged by Docs Team Only

Version(s):

Issue:

Preview:

@sonarqubecloud

Copy link
Copy Markdown

@rhdh-bot

Copy link
Copy Markdown
Collaborator

Shellcheck Analysis Results

Changed shell scripts in this PR: 1

Scripts analyzed:

  • modules/extend_dynamic-plugins-reference/rhdh-supported-plugins.sh

Check the Files changed tab for detailed shellcheck suggestions.

All findings are reported as warnings and won't block the PR.


Automated shellcheck analysis • See shellcheck.net for details

@rhdh-bot

rhdh-bot commented Jul 30, 2026 •

Copy link
Copy Markdown
Collaborator

PR Build Results

Build passed -- 35/35 titles | 79s
Preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-2511/


Content Quality Assessment

CQA Report

  • CQA-00a: Orphaned modules
  • CQA-00b: Directory structure
  • CQA-01: Vale AsciiDoc DITA compliance
  • CQA-02: Verify assembly structure
  • CQA-03: Verify content type metadata
  • CQA-04: Verify module templates
  • CQA-05: Verify required modular elements
  • CQA-06: Verify assemblies follow official template (one user story)
  • CQA-07: Verify TOC depth (max 3 levels)
  • CQA-08: Verify short description content quality
  • CQA-09: Verify short description format
  • CQA-10: Verify titles are brief, complete, and descriptive
  • CQA-11: Verify procedure prerequisites
  • CQA-12: Verify grammar and style (Vale)
  • CQA-13: Verify content matches declared type
  • CQA-14: Verify no broken links
  • CQA-15: Check redirects
  • CQA-16: Verify official product names
  • CQA-17: Verify legal disclaimers for preview features

Summary

Checks: 19 total, 19 pass, 0 fail

19 checks: 19 pass, 0 fail

Run node build/scripts/cqa/index.js --all --fix locally to review and auto-fix issues.


Updated 2026-07-30 15:18:12 UTC

@nickboldt
nickboldt merged commit dee59a3 into redhat-developer:release-1.10 Jul 30, 2026
11 of 12 checks passed

This branch was previously deployed

1 inactive deployment
internal — 4b5cfb89 Deployed Jul 30, 2026 by Omar-AlJaljuli via authorize #10977
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants