Skip to content

Add Support for gemini embeddings#244

Open
gshikhar2021 wants to merge 1 commit into
redhat-data-and-ai:mainfrom
gshikhar2021:gemini-embeddings
Open

Add Support for gemini embeddings#244
gshikhar2021 wants to merge 1 commit into
redhat-data-and-ai:mainfrom
gshikhar2021:gemini-embeddings

Conversation

@gshikhar2021

Copy link
Copy Markdown
Contributor

No description provided.

@gemini-code-assist

Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces support for the Gemini embedding model within the unstructured data pipeline. It expands the existing embedding configuration schema to include Gemini-specific parameters, updates the controller logic to dynamically select and apply configurations based on the chosen model, and ensures compatibility across the codebase including deepcopy methods and equality checks.

Highlights

  • Gemini Embedding Support: Added configuration and logic to support the 'gemini-embedding-2' model for vector embedding generation.
  • Controller Updates: Updated the vector embeddings controller to dynamically handle model-specific configurations and encoding formats.
  • CRD and Schema Updates: Updated CRD definitions and sample files to include the new Gemini embedding configuration schema.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for the gemini-embedding-2 model to the vector embeddings generator, including configuration structs, CRD updates, and controller refactoring to dynamically initialize the embedding client. A critical issue was identified in vectorembeddingsgenerator_controller.go where accessing unstructuredSecret without checking if it is nil could lead to a nil pointer dereference and crash the operator if the controller reconciles before the secret is loaded into memory.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment on lines +236 to +237
endpoint = string(unstructuredSecret.Data[config.Endpoint])
apiKey = string(unstructuredSecret.Data[config.APIKey])

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

There is a potential nil pointer dereference here. unstructuredSecret is a package-level global variable initialized in ControllerConfigReconciler. If the operator restarts, VectorEmbeddingsGeneratorReconciler might reconcile before ControllerConfigReconciler has populated unstructuredSecret in memory (even if the CR status is 'Healthy' in etcd). This will cause a panic and crash the operator.

Please add a defensive check to ensure unstructuredSecret and its Data field are not nil before accessing them.

	if unstructuredSecret == nil || unstructuredSecret.Data == nil {
		return false, fmt.Errorf("unstructured secret is not initialized in memory")
	}

	endpoint = string(unstructuredSecret.Data[config.Endpoint])
	apiKey = string(unstructuredSecret.Data[config.APIKey])

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant