Update auto send to with flair id filter

[dsklikes]

Closes #

💸 TL;DR

📜 Details

Design Doc

Jira

🧪 Testing Steps / Validation

✅ Checks

• CI tests (if present) are passing
• Adheres to code style for repo
• Contributor License Agreement (CLA) completed if not a Reddit employee

[niedzielski]

🔕 typo

[niedzielski]

Can we just leave the type off and infer it?

[dsklikes]

when I leave the type off I get this error on the addSettings(settingsOptions) line

Argument of type '({ defaultValue: string; type: string; name: string; label: string; options: { label: string; value: string; }[]; } | { type: string; name: string; label: string; defaultValue?: never; options?: never; })[]' is not assignable to parameter of type 'SettingsFormField[]'.

I don't think SettingsFormField[] is exposed as a type I can use yet. Is there another way?

[niedzielski]

SettingsFormField[]

I agree! This should be exposed 😞

Is there another way?

My thinking was that we just make this object const like so:

const settingOptions = [
  {
    defaultValue: 'posts',
    type: 'select',
    name: 'listenerObject',
    label: 'Objects to Send On',
    options: [
      { label: 'Posts', value: 'posts' },
      { label: 'Comments', value: 'comments' },
      { label: 'Posts and Comments', value: 'both' },
    ],
  },
  {
    type: 'string',
    name: 'webhook',
    label: 'Webhook URL',
  },
  {
    type: 'string',
    name: 'flairId',
    label: 'Only send when post has this flair ID (optional, will not send comments too)'
  }
] as const;

However, this breaks because the addSettings() input doesn't take a readonly I think it's mutable all the way down so spreading the outer array doesn't work either.

Inlining works and it looks like defaultValue is wrong? The typing says it's supposed to be an array:

Devvit.addSettings([
  {
    defaultValue: ['posts'], // <-- I am array?
    type: 'select',
    name: 'listenerObject',
    label: 'Objects to Send On',
    options: [
      { label: 'Posts', value: 'posts' },
      { label: 'Comments', value: 'comments' },
      { label: 'Posts and Comments', value: 'both' },
    ],
  },
  {
    type: 'string',
    name: 'webhook',
    label: 'Webhook URL',
  },
  {
    type: 'string',
    name: 'flairId',
    label: 'Only send when post has this flair ID (optional, will not send comments too)'
  }
]);

[niedzielski]

🔕 Do we need the type assertion? It looks like we coalesce down to string if no value.