Add fault header inequality matchers#718
Merged
Merged
Conversation
shashankv02
marked this pull request as ready for review
July 6, 2026 18:01
shashankv02
requested review from
HiramSilvey,
konradreiche,
mathyourlife-reddit and
pacejackson
and removed request for
a team
July 6, 2026 18:01
shashankv02
force-pushed
the
fault-inequality-matchers-v0
branch
from
July 6, 2026 18:03
f860fdc to
06509fb
Compare
HiramSilvey
approved these changes
Jul 6, 2026
mathyourlife-reddit
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💸 TL;DR
Port of https://github.snooguts.net/reddit-go/faultbp/pull/30
Adds inequality matching for fault selectors so operators can fault broad request sets while excluding known-safe dependencies without introducing a grouping syntax.
The matcher keys
a,h, andmnow accept!=in addition to=. Multiple matcher segments in a single config are ANDed, so an exclusion list can be written as repeated address inequalities.📜 Details
Syntax
a=,a!=,h=,h!=,m=,m!=.amatcher to match a request.d,D,f,b,F.Examples
🧪 Testing Steps / Validation
Added Unit tests
✅ Checks