test: RBF, handshake disconnect, BIP352 hash-bind - #485
Merged
Merged
Conversation
HTTP testmempoolaccept/sendrawtransaction on the existing run_p2p pad: same-fee replacement is insufficient fee; a higher-fee replacement evicts and is mined. Keep accept.rs fee-rule units. Co-authored-by: Cursor <cursoragent@cursor.com>
V2PlainSession::outbound_bip324 lets the in-tree client send a custom first application message. Assert disconnect, not log strings. handshake_disconnect_log_needles stays for format. Co-authored-by: Cursor <cursoragent@cursor.com>
Cake subscribe still streams one-height result, notifies, then done. Height 2 now pins tweak_from_tx on a P2WPKH→P2TR spend. Drop the dispatch twin. Core functional stays nightly, not a PR gate. Co-authored-by: Cursor <cursoragent@cursor.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Stand the testing-audit rules in TESTING.md (extend catalog journeys, keep guts Core cannot replace, do not grow smoke or two_node). AGENTS.md / CONTRIBUTING / how-we-plan point here so later agents do not make core-functional a PR gate. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three leftover default
cargo testjourneys, plus standing docs so later work stays on this path. Core functional stays nightly; these pins do not wait on it.esplora_broadcast_visible_in_rpc_and_electrum: HTTPtestmempoolaccept/sendrawtransactionreject a same-fee replacement (insufficient fee), then a higher-fee replacement evicts and is mined.testmempoolacceptstill does not evict. Keepaccept.rsfee-rule units.p2p_timeout_getaddr_and_keepalive_ping: after BIP324, the peer closes. Do not deletehandshake_disconnect_log_needles(format).electrum_tweaks_subscribe_streams_then_done: Cake stream still one-height result + notifies +done; height 2 matchestweak_from_txon a P2WPKH→P2TR spend. Deleted the in-processdispatchtwin.TESTING.mdDefault CI is the pin — extend catalog journeys, keep guts Core cannot replace, do not grow smoke ortwo_node.AGENTS.md/CONTRIBUTING.md/docs/how-we-plan.md/docs/core-functional.mdpoint here. Do not makecore-functionala PR gate.Test plan
cargo test -p rbitcoin-test --test cross_surface esplora_broadcast_visible_in_rpc_and_electrumcargo test -p rbitcoin-test --test integration_multinode p2p_timeout_getaddr_and_keepalive_pingcargo test -p rbitcoin-test --test electrum_protocol -- --exact electrum_tweaks_subscribe_streams_then_donecargo test -p rbitcoin-electrum tweaks_subscribefmt,deny,clippy,ast-grep,test,windows,macos,multinode,coverage)