test: Category A twins that do not need Core functional - #483
Merged
Conversation
input_encode_create_fk_not_prev_txid already asserts the v10 layout. Keep create_fk on the spend input; do not re-encode. Co-authored-by: Cursor <cursoragent@cursor.com>
Keep a single dialect pin (DER details plus CLTV paren map). Core feature_dersig/cltv cover the rest when labeled. Co-authored-by: Cursor <cursoragent@cursor.com>
1SUB/1ADD/NEGATE/ABS, SHA1, and empty SIZE already sit in no_unknown_opcode_for_enabled_set. Keep OP_SUCCESS wrappers, VERIFY-then-OP_1, and P2SH-style redeem parse. Co-authored-by: Cursor <cursoragent@cursor.com>
Mature reconstruct already pins height_of_hash, locator, and SH. Keep hash-index rebuild, outs-only output, merkle, cancel, and idempotent confirm_block. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#482 merged. Honest Category A folds that do not wait on Core functional:
input_encode_create_fk_not_prev_txid; dropped from mature reconstruct.testmempoolacceptscript-reject mapping test (DER details + CLTV paren table).no_unknown_opcode_for_enabled_setdeleted; keep OP_SUCCESS / VERIFY-then-OP_1 / P2SH-style.connect_chain_query_surfaceno longer repeats mature height/locator/SH. Keep hash-index rebuild, outs-only output, merkle, cancel, idempotentconfirm_block.Left for later (see
local/testing-audit.md): handshake log needles,decode_rpc_subset, RBF/cluster HTTP, BIP352 hash-bind, Core-functional-required workflow YAML, guts-shaped journeys (two_nodetip-only, smoke lifecycle, BlockCache library).Test plan
consensus_mature_chain_spend_reconstruct_and_scripthashtestmempoolaccept_script_reject_maps_reason_and_detailsno_unknown_opcode_for_enabled_set/eval_sig_then_p2sh_styleconnect_chain_query_surface/spend_edge_and_confirm_idempotent_pathfmt,deny,clippy,ast-grep,test,windows,macos,multinode,coverage)Made with Cursor