test: default compact getblocktxn for a missing extra tx - #476
Merged
Conversation
Default follow-session journey: 2-tx compact with coinbase prefilled and the extra tx absent from mempool must GetBlockTxn. Keep depth-10 full-block serve guts. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing-audit Category B: in-tree P2P client for compact
getblocktxn(the missing-tx path after coinbase-only HB compact).p2p_compact_getblocktxn_missing_extra_tx(default, 20s wall): genesis follow, relay mempool on the follower, 2-tx compact (coinbase prefilled, extra not in mempool) on the live inbound writer. Asserts seed inboundgetblocktxnbytes. Fake prevout — no 100-block pad.getaddr_cache_*stay.Test plan
cargo test -p rbitcoin-test --test integration_multinode p2p_compact_getblocktxn_missing_extra_txcargo test -p rbitcoin-test --test integration_multinode p2p_hb_compact_tip_followcargo test -p rbitcoin-test --test integration_multinode p2p_orphan_child_getdatas_parentfmt,deny,clippy,ast-grep,test,windows,macos,multinode,coverage)Made with Cursor