test: default orphan child GetData of parent - #474
Merged
Conversation
Default follow-session journey: missing-parent child parks and the peer GetDatas the parent. Delete the injected-frame twin. Keep log-not-reject and tokio-worker lock pins. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing-audit Category B: in-tree P2P client for mempool orphan park + parent GetData (the remaining tx-relay gap after HB compact).
p2p_orphan_child_getdatas_parent(default, 20s wall): genesis follow, relay mempool on the follower,-maxtipageso genesis is out of IBD, missing-parent child on the live inbound writer. Assertsorphan_count() == 1and inboundgetdatabytes. Fake prevout — does not admit a parent into mempool.LivePeer::queue_msg: session writer already used for INV flush; not a*_for_testbackdoor.parked_orphan_getdatas_missing_parent.parked_orphan_tx_is_not_logged_as_reject,parked_orphan_on_tokio_worker_getdatas_parent,inv_of_parked_orphan_does_not_getdata. Handshake feeler/self/obsolete needles andgetaddr_cache_*stay.Test plan
cargo test -p rbitcoin-test --test integration_multinode p2p_orphan_child_getdatas_parentcargo test -p rbitcoin-test --test integration_multinode p2p_hb_compact_tip_followcargo test -p rbitcoin-test --test integration_multinode p2p_timeout_getaddr_and_keepalive_pingcargo test -p rbitcoin-net parked_orphanfmt,deny,clippy,ast-grep,test,windows,macos,multinode,coverage)Made with Cursor