Skip to content

[RAPPS-DB] Dependencies#386

Merged
whindsaks merged 4 commits into
reactos:masterfrom
whindsaks:appdepends
May 21, 2026
Merged

[RAPPS-DB] Dependencies#386
whindsaks merged 4 commits into
reactos:masterfrom
whindsaks:appdepends

Conversation

@whindsaks
Copy link
Copy Markdown
Contributor

Use the new dependencies feature from ROS PR 8963 for packages that need it.

Use the new dependencies feature from ROS PR 8963
@binarymaster binarymaster added the enhancement New feature or request label May 14, 2026
Comment thread vc2008sp1run.txt
Copy link
Copy Markdown
Contributor

@katahiromz katahiromz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok.

Comment thread dvdwritenow.txt
Comment thread vc6run.txt
Copy link
Copy Markdown
Collaborator

@julenuri julenuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am happy with this PR.
Not 100% sure if all the dependencies are covered but it's a nice start.

@whindsaks
Copy link
Copy Markdown
Contributor Author

Not 100% sure if all the dependencies are covered but it's a nice start.

I also don't know if I got them all, I mainly just looked at the package descriptions.

@whindsaks whindsaks merged commit 6b263d6 into reactos:master May 21, 2026
1 check passed
@whindsaks whindsaks deleted the appdepends branch May 21, 2026 10:57
Comment thread glidewrapzbag.txt
URLDownload = https://web.archive.org/web/20250414094032/zeckensack.de/glide/archive/glidewrapper084c.exe
SHA1 = 7a9d60a18b660473742b476465e9aea7bd5ab6f8
SizeBytes = 254995
RegName = GlidewrapZbag
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@whindsaks could you explain me what the purpose of RegName is (since it's not systematically present for all packages)?

Copy link
Copy Markdown
Contributor Author

@whindsaks whindsaks May 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By default we assume that the apps registry uninstall subkey has the same name as the package display name. In the cases where it does not, RegName should be set in the package manifest. Rapps uses this to detect if the application is installed or not (CAvailableApplicationInfo::IsInstalled and CAvailableApplicationInfo::InsertVersionInfo).

To find an apps "RegName", just install the app and look in the registry...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants