Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enable WebSocket event reporting to the React Native DevTools Network panel by default.
Resubmission of #58014, which was held on the request initiator of sockets opened from framework code, fixed in #59682.
Motivation/timing
We're looking to migrate Expo to the first party Network panel (native CDP support), which requires WebSocket debugging to not regress features. The alternative is our framework overrides and enables this flag — however that's blocked on a framework-public API to do so. In the case of WS debugging support, this should be ready to roll out to everyone.
Changelog:
[General][Added] - React Native DevTools: Add support for inspecting WebSocket events in the Network panel
Test Plan
Manually tested on both platforms when implemented, and most recently with #59682.