Repository navigation
Compile folly's SanitizeLeak.cpp in Fantom's tester - #59674
Merged
meta-codesync[bot] merged 1 commit intoOct 30, 2026
Merged
Conversation
javache
approved these changes
Oct 30, 2026
|
@javache has imported this pull request. If you are a Meta employee, you can view this in D128600166. |
Collaborator
|
This pull request was successfully merged by @lazerg in a5e2042 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fantom's tester doesn't link when it's built with AddressSanitizer. Under
-fsanitize=address, folly headers likesmall_vector.handSingleton.hcallfolly::detail::annotate_object_leaked_implandannotate_object_collected_impl, and onlyfolly/memory/SanitizeLeak.cppdefines them. Fantom's folly build compilesSanitizeAddress.cppandSanitizeThread.cppbut not that file, so the link fails on both symbols.This adds
folly/memory/SanitizeLeak.cpptofolly_runtime_SRC, which theRCT-Follypodspec already compiles. Without ASan the file only defines those functions, nothing calls them.Fixes #59668
Changelog:
[INTERNAL] [FIXED] - Fix Fantom tester link under AddressSanitizer by compiling folly's SanitizeLeak.cpp
Test Plan:
I couldn't run the full Fantom build here, so I checked the link against folly v2024.11.18.00 (the version Fantom pins) with clang and
-fsanitize=address. A small program usingfolly::small_vector, linked with thefolly_runtimesources it needs, fails with undefinedannotate_object_leaked_impl/annotate_object_collected_impl. AddingSanitizeLeak.cppmakes it link and run.