Repository navigation
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@javache has exported this pull request. If you are a Meta employee, you can view the originating Diff in D128581452. |
javache
force-pushed
the
export-D128581452
branch
from
October 30, 2026 13:12
d11055b to
3d2352f
Compare
meta-codesync
Bot
changed the title
javache
force-pushed
the
export-D128581452
branch
from
October 30, 2026 18:13
3d2352f to
9f8d250
Compare
javache
added a commit
to javache/react-native
that referenced
this pull request
Oct 30, 2026
Summary: Pull Request resolved: react#59670 Keep JavaScript callback and promise values rooted while native owners retain weak lifetime handles. Release inline on the JavaScript thread and dispatch only off-thread cleanup, preventing native invocation or destruction from retaining these values across runtime teardown. Apply the same ownership policy to asynchronous callbacks and promises. This builds on the investigation and reproducer contributed by HyunWoo Lee in react#59579. Changelog: [General][Fixed] - Fix TurboModule callback and async promise cleanup racing runtime teardown [General][Deprecated] - Deprecate CallbackWrapper in favour of LongLivedObjectHandle Differential Revision: D128581452
javache
added a commit
to javache/react-native
that referenced
this pull request
Oct 30, 2026
Summary: Pull Request resolved: react#59670 Keep JavaScript callback and promise values rooted while native owners retain weak lifetime handles. Release inline on the JavaScript thread and dispatch only off-thread cleanup, preventing native invocation or destruction from retaining these values across runtime teardown. Apply the same ownership policy to asynchronous callbacks and promises. This builds on the investigation and reproducer contributed by HyunWoo Lee in react#59579. Changelog: [General][Fixed] - Fix TurboModule callback and async promise cleanup racing runtime teardown [General][Deprecated] - Deprecate CallbackWrapper in favour of LongLivedObjectHandle Differential Revision: D128581452
javache
force-pushed
the
export-D128581452
branch
from
October 30, 2026 18:28
9f8d250 to
21796f0
Compare
javache
added a commit
to javache/react-native
that referenced
this pull request
Oct 30, 2026
Summary: Pull Request resolved: react#59670 Keep JavaScript callback and promise values rooted while native owners retain weak lifetime handles. Release inline on the JavaScript thread and dispatch only off-thread cleanup, preventing native invocation or destruction from retaining these values across runtime teardown. Apply the same ownership policy to asynchronous callbacks and promises. This builds on the investigation and reproducer contributed by HyunWoo Lee in react#59579. Changelog: [General][Fixed] - Fix TurboModule callback and async promise cleanup racing runtime teardown [General][Deprecated] - Deprecate CallbackWrapper in favour of LongLivedObjectHandle Differential Revision: D128581452
javache
force-pushed
the
export-D128581452
branch
from
October 30, 2026 18:42
21796f0 to
3c7ff20
Compare
javache
added a commit
to javache/react-native
that referenced
this pull request
Oct 30, 2026
Summary: Pull Request resolved: react#59670 Keep JavaScript callback and promise values rooted while native owners retain weak lifetime handles. Release inline on the JavaScript thread and dispatch only off-thread cleanup, preventing native invocation or destruction from retaining these values across runtime teardown. Apply the same ownership policy to asynchronous callbacks and promises. This builds on the investigation and reproducer contributed by HyunWoo Lee in react#59579. Changelog: [General][Fixed] - Fix TurboModule callback and async promise cleanup racing runtime teardown [General][Deprecated] - Deprecate CallbackWrapper in favour of LongLivedObjectHandle Differential Revision: D128581452
javache
force-pushed
the
export-D128581452
branch
from
October 30, 2026 19:57
3c7ff20 to
30557e6
Compare
javache
added a commit
to javache/react-native
that referenced
this pull request
Oct 30, 2026
Summary: Pull Request resolved: react#59670 Keep JavaScript callback and promise values rooted while native owners retain weak lifetime handles. Release inline on the JavaScript thread and dispatch only off-thread cleanup, preventing native invocation or destruction from retaining these values across runtime teardown. Apply the same ownership policy to asynchronous callbacks and promises. This builds on the investigation and reproducer contributed by HyunWoo Lee in react#59579. Changelog: [General][Fixed] - Fix TurboModule callback and async promise cleanup racing runtime teardown [General][Deprecated] - Deprecate CallbackWrapper in favour of LongLivedObjectHandle Differential Revision: D128581452
javache
force-pushed
the
export-D128581452
branch
from
October 30, 2026 21:21
30557e6 to
02b9a06
Compare
Summary: Pull Request resolved: react#59670 Keep JavaScript callback and promise values rooted while native owners retain weak lifetime handles. Release inline on the JavaScript thread and dispatch only off-thread cleanup, preventing native invocation or destruction from retaining these values across runtime teardown. Apply the same ownership policy to asynchronous callbacks and promises. This builds on the investigation and reproducer contributed by HyunWoo Lee in react#59579. Changelog: [General][Fixed] - Fix TurboModule callback and async promise cleanup racing runtime teardown [General][Deprecated] - Deprecate CallbackWrapper in favour of LongLivedObjectHandle Differential Revision: D128581452
javache
force-pushed
the
export-D128581452
branch
from
October 30, 2026 21:29
02b9a06 to
e2db9fc
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Keep JavaScript callback and promise values rooted while native owners retain weak lifetime handles. Release inline on the JavaScript thread and dispatch only off-thread cleanup, preventing native invocation or destruction from retaining these values across runtime teardown. Apply the same ownership policy to asynchronous callbacks and promises.
This builds on the investigation and reproducer contributed by HyunWoo Lee in #59579.
Changelog:
[General][Fixed] - Fix TurboModule callback and async promise cleanup racing runtime teardown
[General][Deprecated] - Deprecate CallbackWrapper in favour of LongLivedObjectHandle
Differential Revision: D128581452