Repository navigation
Accept slash alpha in hsl() and percentage alphas in normalize-colors - #59610
Merged
meta-codesync[bot] merged 1 commit intoOct 30, 2026
Merged
meta-codesync[bot] merged 1 commit into
meta-codesync[bot] merged 1 commit into
Conversation
|
@christophpurrer has imported this pull request. If you are a Meta employee, you can view this in D128420977. |
javache
approved these changes
Oct 30, 2026
javache
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
Collaborator
|
This pull request was successfully merged by @lazerg in 3aee67b When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
normalizeColorreturnsnullfor two forms CSS Color 4 accepts, so a view styled with them isn't painted.hsl()only matched three components, while the slash and comma alpha forms were only wired up forhsla(), and every alpha matcher took a plain number, sorgb(0 128 0 / 50%)failed too.hslandhslanow share one pattern, the wayrgbandrgbaalready do, and the alpha slot also takes a percentage, whichparse1divides by 100.Fixes #59602
Changelog:
[GENERAL] [FIXED] -
hsl()colors with an alpha, and alphas given as a percentage such asrgb(0 128 0 / 50%), are no longer rejectedTest Plan:
Added cases to
normalizeColor-test.jsforhsl()with a slash and comma alpha,hsla()without an alpha, and percentage alphas inrgb,rgba,hsl,hslaandhwb. They fail onmainand pass with this change.yarn jest packages/normalize-color packages/react-native/Libraries/StyleSheet packages/react-native/Libraries/Animated: 80 passed