[lazerg]

Summary:

On Android, removing borderStyle: 'dashed' (or 'dotted') from a view leaves its border dashed. Both updatePathEffect overloads in BorderDrawable only set the paint's path effect inside borderStyle?.let, so once borderStyle becomes null nothing resets it and borderPaint keeps the last DashPathEffect. The else null inside the let could never run.

The path effect is now always set, and it is null when borderStyle is null.

Fixes #59600

Changelog:

[ANDROID] [FIXED] - Removing borderStyle from a view no longer leaves its border dashed or dotted

Test Plan:

Added BorderDrawableTest, which draws a dashed border, sets borderStyle to null, draws again and checks the border paint has no path effect. It fails on main and passes with this change. ./gradlew :packages:react-native:ReactAndroid:testDebugUnitTest passes and yarn format-check-kotlin is clean. I didn't run the reproducer on a device.

[github-actions]

Visual regression

No visual differences at b23d0ed48738.

ios: no capture

[meta-codesync]

@javache has imported this pull request. If you are a Meta employee, you can view this in D128304915.