Repository navigation
Delete dead integration-test harness and skipped bridge tests (#59433) - #59433
Merged
Merged
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@christophpurrer has exported this pull request. If you are a Meta employee, you can view the originating Diff in D127294772. |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 24, 2026
…59433) Summary: Pull Request resolved: react#59433 The `RCTTest` runner, `IntegrationTests` bundle, and `RNTesterIntegrationTests` target are fully disabled: every test is commented out or skipped for depending on the removed bridge. Delete the harness, the skipped `RCTDevMenuTests`/`RCTComponentPropsTests`/`RCTImageLoaderTests` class, and all project references. Changelog: [Internal] Differential Revision: D127294772
Visual regression1 visual difference(s) at ios
|
| Expected | Captured |
|---|---|
 |
 |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 27, 2026
…59433) Summary: Pull Request resolved: react#59433 The `RCTTest` runner, `IntegrationTests` bundle, and `RNTesterIntegrationTests` target are fully disabled: every test is commented out or skipped for depending on the removed bridge. Delete the harness, the skipped `RCTDevMenuTests`/`RCTComponentPropsTests`/`RCTImageLoaderTests` class, and all project references. Changelog: [Internal] Differential Revision: D127294772
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 27, 2026
…59433) Summary: Pull Request resolved: react#59433 The `RCTTest` runner, `IntegrationTests` bundle, and `RNTesterIntegrationTests` target are fully disabled: every test is commented out or skipped for depending on the removed bridge. Delete the harness, the skipped `RCTDevMenuTests`/`RCTComponentPropsTests`/`RCTImageLoaderTests` class, and all project references. Changelog: [Internal] Differential Revision: D127294772
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 27, 2026
…59433) Summary: Pull Request resolved: react#59433 The `RCTTest` runner, `IntegrationTests` bundle, and `RNTesterIntegrationTests` target are fully disabled: every test is commented out or skipped for depending on the removed bridge. Delete the harness, the skipped `RCTDevMenuTests`/`RCTComponentPropsTests`/`RCTImageLoaderTests` class, and all project references. Changelog: [Internal] Differential Revision: D127294772
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 27, 2026
…59433) Summary: Pull Request resolved: react#59433 The `RCTTest` runner, `IntegrationTests` bundle, and `RNTesterIntegrationTests` target are fully disabled: every test is commented out or skipped for depending on the removed bridge. Delete the harness, the skipped `RCTDevMenuTests`/`RCTComponentPropsTests`/`RCTImageLoaderTests` class, and all project references. Changelog: [Internal] Differential Revision: D127294772
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 27, 2026
…59433) Summary: Pull Request resolved: react#59433 The `RCTTest` runner, `IntegrationTests` bundle, and `RNTesterIntegrationTests` target are fully disabled: every test is commented out or skipped for depending on the removed bridge. Delete the harness, the skipped `RCTDevMenuTests`/`RCTComponentPropsTests`/`RCTImageLoaderTests` class, and all project references. Changelog: [Internal] Differential Revision: D127294772
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 27, 2026
…59433) Summary: Pull Request resolved: react#59433 The `RCTTest` runner, `IntegrationTests` bundle, and `RNTesterIntegrationTests` target are fully disabled: every test is commented out or skipped for depending on the removed bridge. Delete the harness, the skipped `RCTDevMenuTests`/`RCTComponentPropsTests`/`RCTImageLoaderTests` class, and all project references. Changelog: [Internal] Differential Revision: D127294772
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 27, 2026
…59433) Summary: Pull Request resolved: react#59433 The `RCTTest` runner, `IntegrationTests` bundle, and `RNTesterIntegrationTests` target are fully disabled: every test is commented out or skipped for depending on the removed bridge. Delete the harness, the skipped `RCTDevMenuTests`/`RCTComponentPropsTests`/`RCTImageLoaderTests` class, and all project references. Changelog: [Internal] Reviewed By: andrewdacenko Differential Revision: D127294772
meta-codesync
Bot
changed the title
christophpurrer
force-pushed
the
export-D127294772
branch
from
October 27, 2026 23:06
790cf9f to
f4178c6
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 28, 2026
…59433) Summary: Pull Request resolved: react#59433 The `RCTTest` runner, `IntegrationTests` bundle, and `RNTesterIntegrationTests` target are fully disabled: every test is commented out or skipped for depending on the removed bridge. Delete the harness, the skipped `RCTDevMenuTests`/`RCTComponentPropsTests`/`RCTImageLoaderTests` class, and all project references. Changelog: [Internal] Differential Revision: D127294772
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 28, 2026
…59433) Summary: Pull Request resolved: react#59433 The `RCTTest` runner, `IntegrationTests` bundle, and `RNTesterIntegrationTests` target are fully disabled: every test is commented out or skipped for depending on the removed bridge. Delete the harness, the skipped `RCTDevMenuTests`/`RCTComponentPropsTests`/`RCTImageLoaderTests` class, and all project references. Changelog: [Internal] Reviewed By: andrewdacenko Differential Revision: D127294772
christophpurrer
force-pushed
the
export-D127294772
branch
2 times, most recently
from
October 28, 2026 14:54
0b4dc7a to
e8c00ca
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 28, 2026
…59433) Summary: Pull Request resolved: react#59433 The `RCTTest` runner, `IntegrationTests` bundle, and `RNTesterIntegrationTests` target are fully disabled: every test is commented out or skipped for depending on the removed bridge. Delete the harness, the skipped `RCTDevMenuTests`/`RCTComponentPropsTests`/`RCTImageLoaderTests` class, and all project references. Changelog: [Internal] Reviewed By: andrewdacenko Differential Revision: D127294772
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 28, 2026
…59433) Summary: Pull Request resolved: react#59433 The `RCTTest` runner, `IntegrationTests` bundle, and `RNTesterIntegrationTests` target are fully disabled: every test is commented out or skipped for depending on the removed bridge. Delete the harness, the skipped `RCTDevMenuTests`/`RCTComponentPropsTests`/`RCTImageLoaderTests` class, and all project references. Changelog: [Internal] Differential Revision: D127294772
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 28, 2026
…59433) Summary: Pull Request resolved: react#59433 The `RCTTest` runner, `IntegrationTests` bundle, and `RNTesterIntegrationTests` target are fully disabled: every test is commented out or skipped for depending on the removed bridge. Delete the harness, the skipped `RCTDevMenuTests`/`RCTComponentPropsTests`/`RCTImageLoaderTests` class, and all project references. Changelog: [Internal] Reviewed By: andrewdacenko Differential Revision: D127294772
christophpurrer
force-pushed
the
export-D127294772
branch
2 times, most recently
from
October 29, 2026 21:52
6bd73c2 to
155fe0c
Compare
meta-codesync
Bot
changed the title
christophpurrer
force-pushed
the
export-D127294772
branch
from
October 30, 2026 04:32
155fe0c to
04e4369
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 30, 2026
…59433) Summary: Pull Request resolved: react#59433 The `RCTTest` runner, `IntegrationTests` bundle, and `RNTesterIntegrationTests` target are fully disabled: every test is commented out or skipped for depending on the removed bridge. Delete the harness, the skipped `RCTDevMenuTests`/`RCTComponentPropsTests`/`RCTImageLoaderTests` class, and all project references. Changelog: [Internal] Reviewed By: andrewdacenko Differential Revision: D127294772
meta-codesync
Bot
changed the title
andrewdacenko
approved these changes
Oct 30, 2026
…59433) Summary: Pull Request resolved: react#59433 The `RCTTest` runner, `IntegrationTests` bundle, and `RNTesterIntegrationTests` target are fully disabled: every test is commented out or skipped for depending on the removed bridge. Delete the harness, the skipped `RCTDevMenuTests`/`RCTComponentPropsTests`/`RCTImageLoaderTests` class, and all project references. Changelog: [Internal] Reviewed By: andrewdacenko Differential Revision: D127294772
christophpurrer
force-pushed
the
export-D127294772
branch
from
October 30, 2026 19:27
04e4369 to
97dc6bf
Compare
Collaborator
|
This pull request was successfully merged by @christophpurrer in 5238278 When will my fix make it into a release? | How to file a pick request? |
ide
added a commit
to expo/react-native
that referenced
this pull request
Nov 5, 2026
…ions Deleting the bridge-based image loader tests and RCTImageLoaderHelpers (react#59433) left the `RCTDefineImageURLLoader` and `RCTDefineImageDecoder` invocations at the top of RCTImageLoaderTests.m, whose macros lived in the deleted helper header. Nothing defines them any more, so RNTesterUnitTests does not compile. The test that remains uses only the image cache stub, so the four loader and decoder classes go too. Test plan: `xcodebuild build-for-testing -scheme RNTesterUnitTests` fails on main (RCTImageLoaderTests.m: "expected function body after function declarator") and succeeds with this change; the target then runs 169 tests with 0 failures, RCTImageLoaderCacheTests among them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The
RCTTestrunner,IntegrationTestsbundle, andRNTesterIntegrationTeststarget are fully disabled: every test is commented out or skipped for depending on the removed bridge. Delete the harness, the skippedRCTDevMenuTests/RCTComponentPropsTests/RCTImageLoaderTestsclass, and all project references.Changelog: [Internal]
Reviewed By: andrewdacenko
Differential Revision: D127294772