Skip to content

fix(image): emit onLoadStart before subscribing the response observer on Fabric #58314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SatyamBansal wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −3
Open

fix(image): emit onLoadStart before subscribing the response observer on Fabric #58314

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions packages/react-native/React/Fabric/Mounting/ComponentViews/Image/RCTImageComponentView.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,19 +94,23 @@ - (void)updateState:(const State::Shared &)state oldState:(const State::Shared &
auto oldImageState = std::static_pointer_cast<const ImageShadowNode::ConcreteState>(_state);
auto newImageState = std::static_pointer_cast<const ImageShadowNode::ConcreteState>(state);

[self _setStateAndResubscribeImageResponseObserver:newImageState];

bool havePreviousData = oldImageState && oldImageState->getData().getImageSource() != ImageSource{};

if (!havePreviousData ||
(newImageState && newImageState->getData().getImageSource() != oldImageState->getData().getImageSource())) {
// Loading actually starts a little before this, but this is the first time we know
// the image is loading and can fire an event from this component
// the image is loading and can fire an event from this component.
//
// This has to be emitted before subscribing below: the observer coordinator
// replays an already-`Completed` (or `Failed`) response synchronously, so
// subscribing first can deliver `onLoad`/`onLoadEnd` ahead of `onLoadStart`.
static_cast<const ImageEventEmitter &>(*_eventEmitter).onLoadStart();

// TODO (T58941612): Tracking for visibility should be done directly on this class.
// For now, we consolidate instrumentation logic in the image loader, so that pre-Fabric gets the same treatment.
}

[self _setStateAndResubscribeImageResponseObserver:newImageState];
}

- (void)_setStateAndResubscribeImageResponseObserver:(const ImageShadowNode::ConcreteState::Shared &)state
Expand Down