Skip to content

Cover jsinspector-modern with Stable API guards #58309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
j-piasecki wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Cover jsinspector-modern with Stable API guards #58309

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/react-native/ReactCommon/jsinspector-modern/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ target_link_libraries(jsinspector
glog
jsinspector_network
jsinspector_tracing
react_cxxstableapi
react_featureflags
runtimeexecutor
reactperflogger
Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/jsinspector-modern/ConsoleMessage.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/FrameworksGuard.h>

#include "StackTrace.h"

#include <vector>
Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/jsinspector-modern/ConsoleTask.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/FrameworksGuard.h>

#include <memory>

namespace facebook::react::jsinspector_modern {
Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/jsinspector-modern/ConsoleTaskContext.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/FrameworksGuard.h>

#include "StackTrace.h"

#include <folly/dynamic.h>
Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/jsinspector-modern/ConsoleTaskOrchestrator.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/FrameworksGuard.h>

#include <memory>
#include <mutex>
#include <stack>
Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/jsinspector-modern/EmulationAgent.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/FrameworksGuard.h>

#include "HostTarget.h"
#include "InspectorInterfaces.h"

Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/jsinspector-modern/EnumArray.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/FrameworksGuard.h>

#include <array>
#include <limits>

Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/jsinspector-modern/ExecutionContext.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/FrameworksGuard.h>

#include "UniqueMonostate.h"

#include <optional>
Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/jsinspector-modern/ExecutionContextManager.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/FrameworksGuard.h>

#include <cinttypes>

namespace facebook::react::jsinspector_modern {
Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/jsinspector-modern/FallbackRuntimeAgentDelegate.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/FrameworksGuard.h>

#include "SessionState.h"

#include <jsinspector-modern/InspectorInterfaces.h>
Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/jsinspector-modern/FallbackRuntimeTargetDelegate.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/FrameworksGuard.h>

#include "InspectorInterfaces.h"
#include "RuntimeTarget.h"
#include "SessionState.h"
Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/jsinspector-modern/HostAgent.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/FrameworksGuard.h>

#include "HostTarget.h"

#include <jsinspector-modern/InspectorInterfaces.h>
Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/jsinspector-modern/HostCommand.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/FrameworksGuard.h>

namespace facebook::react::jsinspector_modern {

enum class HostCommand {
Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/jsinspector-modern/HostTarget.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/FrameworksGuard.h>

#include "ExecutionContextManager.h"
#include "HostCommand.h"
#include "InspectorInterfaces.h"
Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/jsinspector-modern/HostTargetTraceRecording.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/FrameworksGuard.h>

#include "HostAgent.h"
#include "HostTarget.h"
#include "InstanceTarget.h"
Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/jsinspector-modern/HostTargetTracing.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/FrameworksGuard.h>

#include "InspectorInterfaces.h"

#include "cdp/CdpJson.h"
Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/jsinspector-modern/InspectorFlags.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/FrameworksGuard.h>

#include <mutex>
#include <optional>

Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/jsinspector-modern/InspectorInterfaces.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/FrameworksGuard.h>

#include <folly/dynamic.h>

#include <functional>
Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/jsinspector-modern/InspectorPackagerConnection.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/FrameworksGuard.h>

#include "WebSocketInterfaces.h"

#include <chrono>
Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/jsinspector-modern/InspectorPackagerConnectionImpl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/FrameworksGuard.h>

#include "InspectorInterfaces.h"
#include "InspectorPackagerConnection.h"

Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/jsinspector-modern/InspectorUtilities.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/FrameworksGuard.h>

#include "InspectorInterfaces.h"

// Utilities that are useful when integrating with InspectorInterfaces.h but
Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/jsinspector-modern/InstanceAgent.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/FrameworksGuard.h>

#include "RuntimeTarget.h"
#include "SessionState.h"

Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/jsinspector-modern/InstanceTarget.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/FrameworksGuard.h>

#include "ExecutionContextManager.h"
#include "RuntimeTarget.h"
#include "ScopedExecutor.h"
Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/jsinspector-modern/NetworkIOAgent.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/FrameworksGuard.h>

#include "InspectorInterfaces.h"
#include "ScopedExecutor.h"

Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/jsinspector-modern/PerfMonitorV2.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/FrameworksGuard.h>

#include <optional>
#include <string>

Expand Down
1 change: 1 addition & 0 deletions packages/react-native/ReactCommon/jsinspector-modern/React-jsinspector.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ Pod::Spec.new do |s|
add_dependency(s, "React-jsinspectornetwork", :framework_name => 'jsinspector_modernnetwork')
add_dependency(s, "React-jsinspectortracing", :framework_name => 'jsinspector_moderntracing')
s.dependency "React-perflogger", version
s.dependency "React-cxxstableapi"
add_dependency(s, "React-oscompat")
add_dependency(s, "React-utils", :additional_framework_paths => ["react/utils/platform/ios"])
if use_hermes()
Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/jsinspector-modern/ReactCdp.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/FrameworksGuard.h>

#include <jsinspector-modern/ExecutionContext.h>
#include <jsinspector-modern/FallbackRuntimeTargetDelegate.h>
#include <jsinspector-modern/HostTarget.h>
Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/jsinspector-modern/RuntimeAgent.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/FrameworksGuard.h>

#include "InspectorInterfaces.h"
#include "RuntimeAgentDelegate.h"
#include "RuntimeTarget.h"
Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/jsinspector-modern/RuntimeAgentDelegate.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/FrameworksGuard.h>

#include <jsinspector-modern/cdp/CdpJson.h>

namespace facebook::react::jsinspector_modern {
Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/jsinspector-modern/RuntimeTarget.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/FrameworksGuard.h>

#include "ConsoleMessage.h"
#include "EnumArray.h"
#include "ExecutionContext.h"
Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/jsinspector-modern/RuntimeTargetGlobalStateObserver.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/FrameworksGuard.h>

#include <jsi/jsi.h>

namespace facebook::react::jsinspector_modern {
Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/jsinspector-modern/RuntimeTargetTracingStateObserver.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/FrameworksGuard.h>

#include <jsi/jsi.h>

namespace facebook::react::jsinspector_modern {
Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/jsinspector-modern/ScopedExecutor.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/FrameworksGuard.h>

#include <react/utils/OnScopeExit.h>
#include <cassert>
#include <functional>
Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/jsinspector-modern/SessionState.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/FrameworksGuard.h>

#include "ExecutionContext.h"
#include "RuntimeAgent.h"

Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/jsinspector-modern/StackTrace.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/FrameworksGuard.h>

#include <memory>

namespace facebook::react::jsinspector_modern {
Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/jsinspector-modern/TracingAgent.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/FrameworksGuard.h>

#include "HostTarget.h"
#include "InspectorInterfaces.h"

Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/jsinspector-modern/UniqueMonostate.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/FrameworksGuard.h>

#include <functional>

namespace facebook::react::jsinspector_modern {
Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/jsinspector-modern/Utf8.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/FrameworksGuard.h>

#include <stdexcept>
#include <vector>

Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/jsinspector-modern/WeakList.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/FrameworksGuard.h>

#include <list>
#include <memory>

Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/jsinspector-modern/WebSocketInterfaces.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/FrameworksGuard.h>

#include <optional>
#include <string>
#include <string_view>
Expand Down
Loading