Preserve __proto__ keys in structuredClone - #58217
Open
OskarEichler wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The structured-clone polyfill writes enumerable keys through assignment, so an own
__proto__data property mutates the clone's prototype and disappears. Route property writes through one helper that retains ordinary assignment on the common path and usesdefinePropertyonly for this exceptional key across array, fast-object, and slow-object traversal.Fixes #58216.
Changelog:
[GENERAL] [FIXED] - Preserve own proto data properties and normal prototypes in structuredClone.
Test Plan:
structuredClone.yarn flow-check: 0 errors.git diff --checkpassed.No UI change; screenshots are not applicable.