Skip to content

Reject boxed Symbols in structuredClone #58213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
OskarEichler wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Reject boxed Symbols in structuredClone #58213

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/react-native/src/private/webapis/structuredClone/__tests__/structuredClone-itest.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ describe('structuredClone', () => {

it('throws with symbols, functions, WeakMap, WeakSet, Promise', () => {
expectDataCloneError(() => structuredClone(Symbol()));
expectDataCloneError(() => structuredClone(Object(Symbol())));
expectDataCloneError(() => structuredClone(() => {}));
expectDataCloneError(() => structuredClone(new WeakMap()));
expectDataCloneError(() => structuredClone(new WeakSet()));
Expand Down
7 changes: 7 additions & 0 deletions packages/react-native/src/private/webapis/structuredClone/structuredClone.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,13 @@ function structuredCloneInternal<T>(value: T): T {
return result;
}

if (value instanceof Symbol) {
throw new DOMException(
"Failed to execute 'structuredClone' on 'Window': Symbol object could not be cloned.",
'DataCloneError',
);
}

// Known non-serializable objects.
if (isNonSerializableObject(value) || isPlatformObject(value)) {
throw new DOMException(
Expand Down
Loading