Skip to content

Clone structuredClone error causes deeply - #58207

Open
OskarEichler wants to merge 1 commit into
react:mainfrom
OskarEichler:codex/fix-structured-clone-error-causes
Open

Clone structuredClone error causes deeply#58207
OskarEichler wants to merge 1 commit into
react:mainfrom
OskarEichler:codex/fix-structured-clone-error-causes

Conversation

@OskarEichler

Copy link
Copy Markdown
Contributor

Summary:

The structured-clone polyfill copies Error.cause by reference and only when truthy. Recursively clone every own cause value after registering the cloned Error in cycle memory, preserving object/circular identity, falsy causes, and the standard non-enumerable descriptor.

Fixes #58206.

Changelog:

[GENERAL] [FIXED] - Deeply clone Error causes, including circular and falsy values.

Test Plan:

  • Exact baseline reproduced three failures: object cause remained shared, circular cause pointed to the input, and false became undefined.
  • Fixed focused Fantom suite: 33/33 passed; result values and circular identity match Node's native structuredClone.
  • Fresh yarn flow-check: 0 errors.
  • Targeted ESLint, Prettier, and git diff --check passed.

No UI change; screenshots are not applicable.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 30, 2026
@facebook-github-tools facebook-github-tools Bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Aug 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

structuredClone preserves Error cause references and drops falsy causes

1 participant