Fix reentrant structuredClone calls - #58205
Open
OskarEichler wants to merge 1 commit into
Open
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
the
Shared with Meta
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The structured-clone polyfill reuses one module-global cycle map based on the assumption that cloning invokes no user code. Enumerable getters can reenter
structuredClone; the inner call then clears the outer map and breaks later circular references. Pass memory explicitly through recursion, preserve the reusable map for ordinary calls, and allocate an independent map only while reentered.Fixes #58204.
Changelog:
[GENERAL] [FIXED] - Preserve circular references when a property getter reenters structuredClone.
Test Plan:
clone.self !== clone).yarn flow-check: 0 errors.git diff --checkpassed.No UI change; screenshots are not applicable.