Make callable module lookup prototype-safe - #58199
Open
OskarEichler wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The legacy bridge stores lazy callable modules in an ordinary object. Unregistered names such as
constructortherefore resolve throughObject.prototype, while registering__proto__mutates the registry prototype. Store the internal string-keyed module map without a prototype and add exact lookup/registration regressions.Fixes #58198.
Changelog:
[GENERAL] [FIXED] - Prevent inherited Object properties from resolving as legacy callable modules.
Test Plan:
constructorreturned an inherited object).__proto__registration.yarn flow-check: 0 errors.git diff --checkpassed.The one-time local Fantom native build required
-Wno-error=deprecated-literal-operatorfor a vendored nlohmann header under the installed Xcode Clang; the test execution itself is green. No UI change; screenshots are not applicable.