Add stable public CallInvoker C++ entry point (#58159) - #58159
Closed
j-piasecki wants to merge 1 commit into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
p: Software Mansion
Summary: Add `<React/CallInvoker.h>` as the canonical public C++ entry point for `CallInvoker`, `NativeMethodCallInvoker`, and `SchedulerPriority`. Guard direct leaf-header inclusion for strict API consumers while preserving existing React Native builds and legacy include paths. Export and stage the umbrella consistently through Buck, CMake, Android Prefab, CocoaPods, and the Apple prebuilt-header inventory. SwiftPM needs no change, since its header mapping for this module already preserves the directory structure. The `ios-prebuild` header configuration needs an explicit entry here: the generic podspec parser only reads the first `header_dir`, so it would have flattened the umbrella into `ReactCommon/` and collided with the existing leaf header of the same basename. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D116921026
meta-codesync
Bot
changed the title
j-piasecki
force-pushed
the
export-D116921026
branch
from
August 28, 2026 06:16
bb8e2ef to
dd36591
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Aug 28, 2026
Summary: Add `<React/CallInvoker.h>` as the canonical public C++ entry point for `CallInvoker`, `NativeMethodCallInvoker`, and `SchedulerPriority`. Guard direct leaf-header inclusion for strict API consumers while preserving existing React Native builds and legacy include paths. Export and stage the umbrella consistently through Buck, CMake, Android Prefab, CocoaPods, and the Apple prebuilt-header inventory. SwiftPM needs no change, since its header mapping for this module already preserves the directory structure. The `ios-prebuild` header configuration needs an explicit entry here: the generic podspec parser only reads the first `header_dir`, so it would have flattened the umbrella into `ReactCommon/` and collided with the existing leaf header of the same basename. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D116921026
j-piasecki
force-pushed
the
export-D116921026
branch
from
August 28, 2026 06:17
dd36591 to
b28aa4f
Compare
|
@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating Diff in D116921026. |
|
This pull request has been merged in 42a3721. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Add
<React/CallInvoker.h>as the canonical public C++ entry point forCallInvoker,NativeMethodCallInvoker, andSchedulerPriority. Guard direct leaf-header inclusion for strict API consumers while preserving existing React Native builds and legacy include paths.Export and stage the umbrella consistently through Buck, CMake, Android Prefab, CocoaPods, and the Apple prebuilt-header inventory. SwiftPM needs no change, since its header mapping for this module already preserves the directory structure.
The
ios-prebuildheader configuration needs an explicit entry here: the generic podspec parser only reads the firstheader_dir, so it would have flattened the umbrella intoReactCommon/and collided with the existing leaf header of the same basename.Changelog:
[Internal]
Reviewed By: cipolleschi
Differential Revision: D116921026