Cover jsiexecutor with Stable API guards (#58133) - #58133
Closed
j-piasecki wants to merge 1 commit into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
p: Software Mansion
|
@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating Diff in D117330790. |
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Aug 26, 2026
Summary: Classifies `jsiexecutor:jsiexecutor` as a private target under the C++ stable API three-tier visibility model. Adds `#include <react/cxxstableapi/PrivateGuard.h>` to both exported headers (`JSIExecutor.h` and `JSINativeModules.h`), and wires the guard dependency into BUCK, CMake and the podspec. The podspec needs no `USE_FRAMEWORKS` header search path edit: it already sets `HEADER_SEARCH_PATHS` to `"$(PODS_TARGET_SRCROOT)/.."` unconditionally, and that resolves to `ReactCommon`. The guards are inert unless a consumer defines `RN_STRICT_API`, so there is no behavior change. Changelog: [Internal] Differential Revision: D117330790
j-piasecki
force-pushed
the
export-D117330790
branch
from
August 26, 2026 07:25
2789014 to
adc0aec
Compare
meta-codesync
Bot
changed the title
jsiexecutor with Stable API guardsjsiexecutor with Stable API guards (#58133)
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Aug 28, 2026
Summary: Classifies `jsiexecutor:jsiexecutor` as a private target under the C++ stable API three-tier visibility model. Adds `#include <react/cxxstableapi/PrivateGuard.h>` to both exported headers (`JSIExecutor.h` and `JSINativeModules.h`), and wires the guard dependency into BUCK, CMake and the podspec. The podspec needs no `USE_FRAMEWORKS` header search path edit: it already sets `HEADER_SEARCH_PATHS` to `"$(PODS_TARGET_SRCROOT)/.."` unconditionally, and that resolves to `ReactCommon`. The guards are inert unless a consumer defines `RN_STRICT_API`, so there is no behavior change. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D117330790
j-piasecki
force-pushed
the
export-D117330790
branch
from
August 28, 2026 06:17
adc0aec to
8678814
Compare
Summary: Classifies `jsiexecutor:jsiexecutor` as a private target under the C++ stable API three-tier visibility model. Adds `#include <react/cxxstableapi/PrivateGuard.h>` to both exported headers (`JSIExecutor.h` and `JSINativeModules.h`), and wires the guard dependency into BUCK, CMake and the podspec. The podspec needs no `USE_FRAMEWORKS` header search path edit: it already sets `HEADER_SEARCH_PATHS` to `"$(PODS_TARGET_SRCROOT)/.."` unconditionally, and that resolves to `ReactCommon`. The guards are inert unless a consumer defines `RN_STRICT_API`, so there is no behavior change. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D117330790
j-piasecki
force-pushed
the
export-D117330790
branch
from
August 28, 2026 06:17
8678814 to
a828218
Compare
|
This pull request has been merged in eda9f45. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Classifies
jsiexecutor:jsiexecutoras a private target under the C++ stable API three-tier visibility model. Adds#include <react/cxxstableapi/PrivateGuard.h>to both exported headers (JSIExecutor.handJSINativeModules.h), and wires the guard dependency into BUCK, CMake and the podspec.The podspec needs no
USE_FRAMEWORKSheader search path edit: it already setsHEADER_SEARCH_PATHSto"$(PODS_TARGET_SRCROOT)/.."unconditionally, and that resolves toReactCommon.The guards are inert unless a consumer defines
RN_STRICT_API, so there is no behavior change.Changelog: [Internal]
Reviewed By: cipolleschi
Differential Revision: D117330790