fix(android): add buildConfig = true, to fix build error on AGP 9 - #1065
Draft
wperkins-micron wants to merge 1 commit into
Draft
wperkins-micron wants to merge 1 commit into
wperkins-micron wants to merge 1 commit into
Conversation
Fixes a build error on AGP 9. See also: * react-native-checkbox/react-native-checkbox#257 * react-native-checkbox/react-native-checkbox@2794ece
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I am currently updating an Android app from React Native 0.77.3 to 0.87.1. I followed the upgrade helper, which also bumps the Gradle version from 8.10.x to 9.4.1. Attempting to build and run the app under AGP 9 causes the build to fail with the following error:
This is fixed by adding the following block of code inside the
androidblock inandroid/build.gradle:See also a similar issue and open pull request for another RN community module:
No AI was used in the creation of this patch or pull request in any way.
Test Plan
What's required for testing (prerequisites)?
React Native 0.87.1, Gradle 9.4.1
What are the steps to reproduce (after prerequisites)?
After making this change, I ran
npm run android. The build process now successfully made it past this module, failing later on another module that has this same issue. (I will mark this pull request as Ready once I have gotten the full app to build successfully.)Compatibility
This change is only relevant to building on Android.
Checklist
README.mdexample/App.js)it's a 3-line fix