Skip to content

fix(build): dispatch both native targets for all - #1340

Merged
krizzu merged 1 commit into
react-native-async-storage:mainfrom
OskarEichler:codex/asyncstorage-build-all
Aug 31, 2026
Merged

fix(build): dispatch both native targets for all#1340
krizzu merged 1 commit into
react-native-async-storage:mainfrom
OskarEichler:codex/asyncstorage-build-all

Conversation

@OskarEichler

@OskarEichler OskarEichler commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Summary

Run Android and Apple builders for the native build script's all option.

Compatibility / observable behavior

Only the developer build script changes; no runtime API or package schema change.

Related to #1331. This is a focused part of a source review; it does not claim the entire repository is bug-free.

Test Plan

  • sh -n and actual case-dispatcher with stub builders: android/apple unchanged; all changes from exit 127 (undefined build_all) to both builders in order; invalid targets still exit 1.
  • Upstream yarn build:js, yarn test:ts (6 tasks), yarn test:lint (6 tasks), yarn test:format and git diff --check pass on the combined review checkout.
  • No checked-in test/spec files changed. Reproductions were isolated and used synthetic data, not production/user storage.
  • The combined 3.1.1 backport passes consumer immutable install/lint, both products' Android Debug and iOS Simulator Debug builds, four production Metro bundles, 13 web targets and four browser-extension targets. Published native framework binaries are unchanged. React Doctor: 100/100.
  • Shared-storage testAndroidHostTest, macosArm64Test and iosSimulatorArm64Test pass with Java 21. The first Android run used Java 17 and failed Robolectric's SDK 36/JDK check; rerunning with the project's documented JDK fixed the environment failure without a source workaround.
  • Windows/WinRT runtime, signed releases and physical-device behavior have not been verified locally.

@changeset-bot

changeset-bot Bot commented Aug 27, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: f7f5a46

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@krizzu krizzu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sense

@krizzu
krizzu merged commit 7fddfcd into react-native-async-storage:main Aug 31, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants