Skip to content

TASK-122: a bullet slot is not a cell, so render --write invents no padding - #25

Merged
ranjiao merged 18 commits into
feat/work-modesfrom
coding/task-122-bullet-padding
Aug 20, 2026
Merged

TASK-122: a bullet slot is not a cell, so render --write invents no padding#25
ranjiao merged 18 commits into
feat/work-modesfrom
coding/task-122-bullet-padding

Conversation

@ranjiao

@ranjiao ranjiao commented Aug 20, 2026

Copy link
Copy Markdown
Owner

The bug

bin/perry_store.py § describe_cell's disagreement branch defaulted the
padding to one space on each side. For a table cell that is right —
render_line joins on |, a character carrying no whitespace of its own. For
a bullet slot it is duplication: slot_descriptor's literal span already
holds the separator.

input           '- Repo layout: single'
literal span    '- Repo layout: '        ← the space after the colon is already here
lead / trail    ' ' / ' '                ← invented on top of it
rendered        '- Repo layout:  split '

Two spaces after the colon, and a trailing one git diff --check reports.
bin/perry_md_store.py:972 prints, in its own refusal message, `<tool> render --write` to bring the file back in line, so the tool was
instructing the reader into the damage.

The rule

Stated once, where the padding is decided, keyed on the same escape flag that
already distinguishes a cell from a slot: only a table cell may be handed
padding it did not come with.
The whitespace-only branch follows the same
rule — a bullet keeps that whitespace whole and on the left, where the
separator it follows is.

Verification (V3)

  1. - Repo layout: single + a store holding split renders
    - Repo layout: split, byte-exact.
  2. Reverting the rule reddens the three bullet cases and NOT the table-cell
    case
    (test_a_table_cell_that_lost_its_padding_is_still_given_it_back
    stays green, as do test_a_track_row and the blank-marker test). The two
    paths are genuinely separated.
  3. test_the_declared_blank_marker_survives_the_bullet_path green, unedited.
  4. Run, not asserted — a real .perry/config.md in a temp git repo, drifted,
    perry-config render --write, then git diff --check: silent, exit 0. Also
    covered as a test.
  5. python3 tests/parallel -j 4: 65 modules · 1934 tests, one pre-existing red
    module (test_diagnose, 2 failures about dangling DESIGN-900 / REL-00 /
    ZZZ-404) identical to the baseline measured on this branch point.
    bash tests/run agrees. python3 bin/perry-lint 0 errors.
    git diff --check clean. git diff -- perry/ empty.

Diff size

Own code diff: 2 files, +42 / −7. The PR's file count is inflated because
feat/work-modes is ahead of origin.

🤖 Generated with Claude Code

ranjiao and others added 18 commits August 20, 2026 20:04
…gnature

C1 (TASK-127) is dispatched. C3 (TASK-128) is a human gate and is in
review with the exact edit written out. C4 (TASK-129) is blocked on it.
TASK-126 is the reason test_diagnose is still red after the merge.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
…ao 2026-08-20)

DESIGN-007 step 2. The third ownership change to the hand-off contract
and the second to carry its own signature.

- SKILL.md § The hand-off contract: one row, work's cell only. goals and
  decide are byte-identical across the edit. 20410 → 20457 of a 20480 cap.
- schema/state-schema.json: role-card owner user → work, and the note that
  argued for `user` rewritten to record what the change cost rather than
  being deleted.
- tests/test_ownership.py: the mapping the check demanded once the contract
  listed the path. It refused first, which is what it is for.
- reference/hand-off-contract.md: the account, including the 23 bytes of
  router headroom left and the stale "Two changes" paragraph.

Unblocks TASK-129 (Agent becomes a store).

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
TASK-133. One track added to .perry/config.md § Tracks: intake, mode
queue. One file changed, zero state files rewritten (BOARD.md,
tasks.jsonl and OKR.md byte-identical by md5).

The result: a queue-track row carried a kr: edge to a project-mode KR
with no friction at all. attribution.linked 4 → 5, no error, no warning.
There is no mechanical gate anywhere — 'No objectives cascade' is prose
in modes/queue.md and nothing else.

Three defects found on the way, none of them the one under test:
TASK-135 no existing row can be moved to a track, TASK-136 a track SLA
is never measured against anything, TASK-137 a new queue row is born in
the second stage.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
…r ran

TASK-138, and it is why CI has been red on every PR.

GNU coreutils `stat -f` is `--file-system`: it exits 0 and prints four
lines about the filesystem. So `stat -f %m || stat -c %Y || echo 0`
never reaches either fallback on Linux, mtime() returned a paragraph,
and `$((now - last))` died with "syntax error in expression". Green on
every mac, red on every CI run.

Three scripts carried it. perry-update-check runs on EVERY Perry
invocation, so on Linux the 7-day throttle has been reading a filesystem
block as a timestamp all along, silently.

The fix tries the GNU form first — BSD stat rejects `-c` outright, which
`-f` does not — and accepts an answer only if it is all digits, because
an exit code is not evidence that the output means what was asked for.

Reproduced on this mac with a fake GNU stat on PATH, so the defect is
catchable without a Linux box; reverting the fix reddens the new tests.
A grep guard fails if the chain reappears anywhere in bin/.

Also fixes two checks that read this repository's live state as their
expected value, both reddened by declaring the first track (TASK-133):
test_md_store asserted every config record is a `setting`, and
test_track_attribution asserted Perry itself has no track register. Both
now derive the expectation from the file, and the second proves its
no-op property on a project that has no register rather than on this one.

Adds DESIGN-008 (draft): Mode is three axes wearing one name.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
#1 went against the document's own draft. It had bolded three axes;
what beat it is that the third one needs no axis to exist — Default
rung is already an overridable column, and this repository overrode it
on the intake track today without any axis machinery. Two axes, and
the rung stays the plain field it is.

#2 was the one genuinely contested slot and resolved to 'do not declare
it at all': each spine value implies exactly one unit, so a declarable
field could only ever hold a wrong value, and it would surface only when
two presets are mixed — which is the case this design creates.

#3, #4 and #6 are one decision in three places, all forced by goal 2:
the preset name survives, a blank leg inherits from the preset, nothing
migrates. #5 follows #3.

Title, section 5.1's example, section 5.2's slot table, one risk row and
section 8's second open question all moved as a consequence.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
…ASK-139)

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Pre-flight clean: 10/10 required sections non-empty, 0 open decisions,
5 implementation steps. The advisory input-quality pass added section
5.4 (blast radius, nine surfaces) and a detection signal on every risk
— the same two gaps DESIGN-003 closed at its own lock. One point was
overridden rather than fixed and recorded as overridden: decision #5
is arguably agent-decidable.

DESIGN-003 section 9 now points here, with the measurement that made
this a revision rather than an opinion.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Step 1 only. Steps 2-5 are functions of its output and stay closed until
it lands, so their acceptance criteria can be falsifiable rather than
'per step 1's table'.

Dispatch pre-flight refuses on `design/` and this one is a genuine hit,
not a false positive: the row's deliverable is an edit to a locked
design document.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Local is ahead 10 / behind 13 with all four PRs merged on the remote —
that is step 1 of the handoff, because the same divergence cost half of
today.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The user asked whether TASK-037's blocked status was right. It was not,
and it was not alone: both rows had every dependency closed, TASK-037 on
TASK-092 and TASK-045 on the TASK-044 -> TASK-047 chain.

bin/perry-task:4728 reads the stored status before blocked_by, so a
stale 'blocked' can never be contradicted by the computed state — both
rows carried blocked_by [] and startable False at once. Opened TASK-141.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The signal was already firing. next_action_cites_closed named exactly
TASK-037 and TASK-045, and earlier the same day the PMO read that check
as prose hygiene and rewrote the cells to silence it. A check that
reports a pattern without its meaning gets suppressed by whoever reads it.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
PR #14 (TASK-100) put both store files into claims[] at e3f8621. PR #15
(TASK-110) shipped test_state_cost asserting the pre-claim world:
`perry/tasks.jsonl (unclaimed)` and `.perry/events.jsonl` rolling up
under the `.perry/` row. Each was green on its own base; the merge was
red on two tests neither PR could have seen.

The behaviour never changed — only which row states it. The history
assertion now reads the file's own row and its number is unchanged. The
unclaimed-file test writes a file nothing will ever claim rather than
borrowing one that happened to be unclaimed that week; it needed a
commit too, because the tool reads git.

Both proved non-vacuous by mutation: pointing the row back at `.perry/`
reddens one, dropping the commit reddens the other.

Closes TASK-100, TASK-111, TASK-127, TASK-133 at V3 — all four verified
locally now that the merged code is here. TASK-094 stays open: its PR
merged but verification item 1 is unmet.

Opens TASK-143.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>


Both pre-flights refuse and both releases were given by the user on
2026-08-20. Recorded in evidence rather than left in chat: TASK-126's hit
reads as a false positive (the fragment matched a filename, not the
execute stage) and TASK-140's does not (the row really does rewrite a
locked design document).

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
…ted ratio

Writing the spec found the row's title understates it. The numbers are
not absent, they are wrong in both directions: P-O1.1 reads 0-of-1 with
all four linked tasks closed, and P-O2.2 reads met while TASK-094
measured 13 splits and 87 resolutions still live. Six of eight phase KRs
have target 0.0 and an unset current defaults to 0.0, so every
drive-to-zero KR reads as met on the day it is written.

The pre-flight refused on state-schema.json (claim surface). Scoped out
rather than escalated: the row adds payload fields, not declared shape,
and the agent is told to stop and report if that turns out to be wrong.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
…live reproduction

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
…padding

`describe_cell`'s disagreement branch defaulted `lead`/`trail` to one space
each. For a table cell that is right — `render_line` joins on `|`, which
carries no whitespace of its own. For a bullet slot it is duplication: the
literal span before the slot already holds the separator, so
`- Repo layout: single` repaired against a store holding `split` came back
`- Repo layout:  split ` — two spaces after the colon, and a trailing one
`git diff --check` reports.

That mattered because `bin/perry_md_store.py` prints, in its own refusal
message, "`<tool> render --write` to bring the file back in line". The tool
was instructing the reader into the damage.

The rule is now stated once, where the padding is decided, and keyed on the
same `escape` flag that already tells a cell from a slot: only a cell may be
handed padding it did not come with. The whitespace-only branch follows the
same rule — a bullet keeps that whitespace whole and on the left, where the
separator it follows is, rather than splitting it across both sides.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@ranjiao
ranjiao merged commit 60916fb into feat/work-modes Aug 20, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant