Repository navigation
chore: clear all build warnings - #1254
Open
futurepastori wants to merge 4 commits into
Open
futurepastori wants to merge 4 commits into
futurepastori wants to merge 4 commits into
Conversation
- Remove dead IaC helpers (json.rs value wrappers; a dead CaC schema field set in migrate.rs) and an unused import in variable.rs. - Gate the test-only find_railway_file behind cfg(test). - Drop a dead local in cac_deprecation.rs. - Keep reserved/intentional surfaces but silence them correctly: iac module re-exports use #[allow(unused)] (umbrella, was the wrong lint); compiler patch-composition path and variable_edit plain renderer get #[allow(dead_code)] with intent noted. cargo build is now warning-free; 1761 tests pass.
futurepastori
force-pushed
the
victor/clear-build-warnings
branch
from
October 6, 2026 15:08
4572eeb to
32dc792
Compare
…warnings Resolved src/iac/mod.rs: kept master's expanded re-export lists (normalize_cdn, VariablePolicyReport, format_variable_policy_line) under the PR's #[allow(unused)] attribute.
render_service_body, render_source (config/mod.rs) and find_all_cac_files (cac_deprecation.rs) are only called from tests and reintroduced dead-code warnings after merging master; gate them like find_railway_file so the build stays warning-free. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cargo buildis now warning-free (was 18 warnings).Deleted (dead, self-contained):
iac/json.rs:clone_value,as_object,as_object_mut,merge_objects(trivial std wrappers, unused).commands/config/migrate.rs: CaC schema fields we parse but never emit (nixpacks_config_path, restart-policy, sleep, draining/overlap). (Same removal also lands in feat(iac): guided, reversible CaC→IaC migration (cutover/undo/status) #1253; identical deletions merge cleanly.)commands/variable.rs: unused importget_service_variables.util/cac_deprecation.rs: deaddisplay_path/shownlocal.Gated / suppressed (reserved or test-only, not deleted):
commands/config/mod.rs:find_railway_fileis test-only →#[cfg(test)].iac/mod.rs: module re-exports used#[allow(dead_code)](wrong lint —unused_importsstill fired, and it was silently suppressing a whole re-exported tree). Switched to the umbrella#[allow(unused)], which is correct and keeps the module's public surface intact.iac/compiler.rs:compose_patch/add_deletion_markers/map_from_str— reserved patch-composition path,#[allow(dead_code)]with intent noted.controllers/variable_edit.rs:render_variable_plan_plain(not my domain;#[allow(dead_code)]rather than deleting someone's helper).Test
cargo build: 0 warnings.cargo test --bin railway: 1761 passed.