Repository navigation
test(ca): stabilize Windows terminal regression tests - #1198
Merged
Merged
Conversation
codyde
marked this pull request as ready for review
September 11, 2026 21:28
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stabilize the Windows terminal tests that failed in the post-merge CI run for #1193. That run had ten link/scrollback failures with empty terminal screens. #1195 fixed one short wait, but other affected tests still used 1–6 second polling loops that silently continued on timeout.
Validation
cargo fmt --all -- --check: passed.git diff --check: passed.cargo clippy --locked --all-targets --all-features: passed (existing warnings).cargo test --locked): 1,595 passed, 2 ignored.235649a: all checks passed, including Windows/Linux/macOS tests, the i686 Windows GNU release build, lints, compile check, installer checks, and the release label check.Merge investigation
The pre-merge checks on #1193 passed; the Windows failures occurred on the merged commit. The latest #1195 Windows run passed as well. Separately,
mastercurrently has an empty required-status-check list, so failing CI does not block merges through branch protection.