Skip to content

test(ca): stabilize Windows terminal regression tests - #1198

Merged
codyde merged 3 commits into
masterfrom
cody/fix-windows-terminal-tests
Nov 10, 2026
Merged

codyde merged 3 commits into
masterfrom
cody/fix-windows-terminal-tests

Conversation

@codyde

@codyde codyde commented Sep 11, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Stabilize the Windows terminal tests that failed in the post-merge CI run for #1193. That run had ten link/scrollback failures with empty terminal screens. #1195 fixed one short wait, but other affected tests still used 1–6 second polling loops that silently continued on timeout.

  • Share a test-only, 15-second bounded wait for expected screen output. It returns as soon as output arrives and reports the expected text and actual screen at the caller on timeout.
  • Wait for complete output before asserting link hit-testing, wrapped URLs, scrollback, resizing, and rendering. Negative link tests also wait for their fixture text, avoiding assertions against empty screens.
  • Send a fresh completion marker after the churn fixture's final resize. Shrinking the screen can discard bottom rows (including an already-delivered tail), and sending the marker also returns the viewport to live output.

Validation

  • cargo fmt --all -- --check: passed.
  • git diff --check: passed.
  • Local TUI suite: 399 passed, 1 ignored.
  • cargo clippy --locked --all-targets --all-features: passed (existing warnings).
  • Churn regression after the final-resize fix: 50/50 repeated runs passed.
  • Full local suite (cargo test --locked): 1,595 passed, 2 ignored.
  • CI on final commit 235649a: all checks passed, including Windows/Linux/macOS tests, the i686 Windows GNU release build, lints, compile check, installer checks, and the release label check.

Merge investigation

The pre-merge checks on #1193 passed; the Windows failures occurred on the merged commit. The latest #1195 Windows run passed as well. Separately, master currently has an empty required-status-check list, so failing CI does not block merges through branch protection.

@codyde codyde added the release/skip Author no release label Sep 11, 2026
@codyde
codyde marked this pull request as ready for review September 11, 2026 21:28
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@codyde
codyde merged commit b6f4173 into master Nov 10, 2026
8 checks passed
@codyde
codyde deleted the cody/fix-windows-terminal-tests branch November 10, 2026 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release/skip Author no release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant