Repository navigation
feat: tidy the node overview and show the BMC address - #30
Merged
Merged
Conversation
Resource class moves into Identity and state, and Management gains a BMC address read from driver_info.redfish_address. It shows a dash when driver_info or the field is absent, since not every driver sets it. As on the node table, the maintenance reason now lives in the Maintenance field instead of a field of its own, and a node out of maintenance shows a dash rather than "disabled". driver_info joins the node schema as an optional record; the BFF already redacts its credentials. Mock nodes get a placeholder redfish_address.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
driver_info.redfish_address. It shows—whendriver_infoor the field is missing.—instead of "disabled".driver_infoto the node schema as an optional record. The BFF already redacts credentials in it. Mock nodes get a placeholderredfish_addresson anexample.invalidhost.Testing
npm run typecheck,npm testandnpm run test:e2epass.redfish_addresscase, since every mock node has one.