Skip to content

feat: tidy the node overview and show the BMC address - #30

Merged
cardoe merged 1 commit into
mainfrom
feat/overview-bmc-address
Nov 19, 2026
Merged

cardoe merged 1 commit into
mainfrom
feat/overview-bmc-address

Conversation

@cardoe

@cardoe cardoe commented Nov 19, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Move Resource class into the Identity and state card.
  • Add a BMC address field under Management, read from driver_info.redfish_address. It shows — when driver_info or the field is missing.
  • Fold the maintenance reason into the Maintenance field, as on the node table. A node not in maintenance shows — instead of "disabled".
  • Add driver_info to the node schema as an optional record. The BFF already redacts credentials in it. Mock nodes get a placeholder redfish_address on an example.invalid host.

Testing

  • npm run typecheck, npm test and npm run test:e2e pass.
  • New e2e test covers where Resource class and BMC address appear and that "Maintenance reason" is gone.
  • Not covered: the missing-redfish_address case, since every mock node has one.

Resource class moves into Identity and state, and Management gains a BMC
address read from driver_info.redfish_address. It shows a dash when
driver_info or the field is absent, since not every driver sets it.

As on the node table, the maintenance reason now lives in the Maintenance
field instead of a field of its own, and a node out of maintenance shows a
dash rather than "disabled".

driver_info joins the node schema as an optional record; the BFF already
redacts its credentials. Mock nodes get a placeholder redfish_address.
@cardoe
cardoe merged commit 0b81e7a into main Nov 19, 2026
7 checks passed
@cardoe
cardoe deleted the feat/overview-bmc-address branch November 19, 2026 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant