Skip to content

feat: use the brand mark as the tab icon - #28

Merged
cardoe merged 1 commit into
mainfrom
feat/favicon
Nov 17, 2026
Merged

cardoe merged 1 commit into
mainfrom
feat/favicon

Conversation

@cardoe

@cardoe cardoe commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Adds the default server icon (the one beside the product name) as an SVG favicon, in the primary blue, switching shade with prefers-color-scheme.
  • BrandTitle swaps the icon for BRAND_LOGO_URL when one is configured, so the tab matches the in-app mark. It drops the type hint for a custom logo, since it could be any image type.
  • The SVG lives in src/assets and is linked from index.html, so Vite hashes it into the build (publicDir is off outside mock mode, so public/ would not ship).
  • Credits Lucide (ISC) and Feather (MIT) for the icon in NOTICE.

Test plan

  • npm run typecheck, npm test (216 pass)
  • npm run build: dist/index.html links the hashed SVG
  • npm run test:e2e (28 pass), including a new check that the icon link resolves to an SVG
  • Not checked by eye in Safari; I believe SVG favicons need a recent Safari, so older ones may show no icon
  • Custom BRAND_LOGO_URL path not exercised in a browser

Add the default server icon as an SVG favicon, in the app's primary blue and
following the light/dark colour scheme. A configured BRAND_LOGO_URL replaces it
once the session loads, the same as it replaces the icon beside the name.

The icon derives from Lucide (ISC, originally Feather, MIT), credited in NOTICE.
@cardoe
cardoe merged commit d039823 into main Nov 17, 2026
7 checks passed
@cardoe
cardoe deleted the feat/favicon branch November 17, 2026 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant