Repository navigation
feat: use the brand mark as the tab icon - #28
Merged
Merged
Conversation
Add the default server icon as an SVG favicon, in the app's primary blue and following the light/dark colour scheme. A configured BRAND_LOGO_URL replaces it once the session loads, the same as it replaces the icon beside the name. The icon derives from Lucide (ISC, originally Feather, MIT), credited in NOTICE.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
prefers-color-scheme.BrandTitleswaps the icon forBRAND_LOGO_URLwhen one is configured, so the tab matches the in-app mark. It drops thetypehint for a custom logo, since it could be any image type.src/assetsand is linked fromindex.html, so Vite hashes it into the build (publicDiris off outside mock mode, sopublic/would not ship).NOTICE.Test plan
npm run typecheck,npm test(216 pass)npm run build:dist/index.htmllinks the hashed SVGnpm run test:e2e(28 pass), including a new check that the icon link resolves to an SVGBRAND_LOGO_URLpath not exercised in a browser