Skip to content

fix: align node table headings and fold maintenance reason into its column - #27

Merged
cardoe merged 2 commits into
mainfrom
fix/node-table-columns
Nov 17, 2026
Merged

cardoe merged 2 commits into
mainfrom
fix/node-table-columns

Conversation

@cardoe

@cardoe cardoe commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Column headings drifted off their cells when the table scrolled sideways. The header and the virtualized rows are separate grids, both min-width: max-content, and absolutely positioned rows do not count toward max-content, so each resolved its fr tracks against a different width. Columns now declare min (rem) and optional grow; the header and rows share the summed minimum width.
  • Removed the Maintenance reason column. A node in maintenance shows its reason in the Maintenance badge (truncated, full text on hover), or "maintenance" when none is recorded. Not in maintenance still shows "no".
  • CSV export still includes the reason as its own field. The Columns picker lists only columns the table has.

Test plan

  • npm run typecheck, npm test (216 pass)
  • npm run test:e2e (30 pass), including a new test that compares each heading's x and width with its cell at 900px; it fails on the old max-content layout (one column 80px off)
  • New e2e test: no "Maintenance reason" column, reasons shown in the Maintenance column, bare "maintenance" when none, tooltip on hover

…olumn

The header and the virtualized rows are separate grids, both sized with
min-width: max-content. Absolutely positioned rows do not count toward
max-content, so once the table scrolled sideways the two resolved their fr
tracks against different widths and the headings drifted off their cells.
Columns now declare a minimum in rem, and the header and rows share the
summed minimum width.

The Maintenance reason column is gone: a node in maintenance shows its reason
in the Maintenance badge, or "maintenance" when none is recorded. CSV export
still carries the reason as its own field.
@cardoe
cardoe force-pushed the fix/node-table-columns branch from 566b0f2 to e531cf8 Compare November 17, 2026 20:52
@cardoe
cardoe merged commit 05e506b into main Nov 17, 2026
7 checks passed
@cardoe
cardoe deleted the fix/node-table-columns branch November 17, 2026 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant