Repository navigation
fix: align node table headings and fold maintenance reason into its column - #27
Merged
Merged
Conversation
…olumn The header and the virtualized rows are separate grids, both sized with min-width: max-content. Absolutely positioned rows do not count toward max-content, so once the table scrolled sideways the two resolved their fr tracks against different widths and the headings drifted off their cells. Columns now declare a minimum in rem, and the header and rows share the summed minimum width. The Maintenance reason column is gone: a node in maintenance shows its reason in the Maintenance badge, or "maintenance" when none is recorded. CSV export still carries the reason as its own field.
cardoe
force-pushed
the
fix/node-table-columns
branch
from
November 17, 2026 20:52
566b0f2 to
e531cf8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
min-width: max-content, and absolutely positioned rows do not count towardmax-content, so each resolved itsfrtracks against a different width. Columns now declaremin(rem) and optionalgrow; the header and rows share the summed minimum width.Test plan
npm run typecheck,npm test(216 pass)npm run test:e2e(30 pass), including a new test that compares each heading's x and width with its cell at 900px; it fails on the oldmax-contentlayout (one column 80px off)