Repository navigation
feat: Add Demand node. - #915
Merged
Merged
Conversation
Batch21
requested changes
Oct 22, 2026
Comment on lines
+43
to
+47
| /// A node that represents an input to the model, such as a river inflow or a reservoir inflow. | ||
| /// | ||
| /// Flow is constrained by the `max_flow` and `min_flow` metrics. If `max_flow` is not specified, | ||
| /// the flow is unconstrained. If `min_flow` is not specified it defaults to 0. | ||
| /// the flow is unconstrained. If `min_flow` is not specified it defaults to 0. See | ||
| /// [`crate::nodes::DemandNode`] for an output with a required `max_flow` and a `Deficit` attribute. |
Contributor
There was a problem hiding this comment.
This comment should be on the OutputNode not InputNode?
| /// The deficit of the inflow compared to the `max_flow` metric. | ||
| Deficit, | ||
| /// The value of the `max_flow` metric. Requires `max_flow` to be defined. | ||
| MaxFlow, |
Contributor
There was a problem hiding this comment.
if this attribute is referenced by another compoenent but max flow is not set then the model will pass the validation but error duing build. This is probably something the validation should capture.
Batch21
approved these changes
Nov 7, 2026
Batch21
left a comment
Batch21
left a comment
Contributor
There was a problem hiding this comment.
Looks ready to go. I assume the merging main into this should fix the CI.
Adds a new Demand node that requires a max_flow attribute and therefore can produce a Deficit attribute in all cases. Removes the Deficit attribute from Output node. # Conflicts: # Cargo.lock
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new Demand node that requires a max_flow attribute and therefore can produce a Deficit attribute in all cases.
Removes the Deficit attribute from Output node.