Skip to content

Lock on hislip - #643

Draft
hb020 wants to merge 30 commits into
pyvisa:mainfrom
hb020:lock-on-hislip
Draft

Lock on hislip#643
hb020 wants to merge 30 commits into
pyvisa:mainfrom
hb020:lock-on-hislip

Conversation

@hb020

@hb020 hb020 commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Preparing, this is to be applied AFTER #626

  • Closes Allow locking on hislip #635
  • Executed pre-commit with no errors
  • The change is fully covered by automated unit tests
  • Documented in docs/ as appropriate
  • Added an entry to the CHANGES file

@codecov

codecov Bot commented Sep 1, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 76.38484% with 81 lines in your changes missing coverage. Please review.
✅ Project coverage is 51.04%. Comparing base (048df06) to head (d2bc3d7).

Files with missing lines Patch % Lines
pyvisa_py/protocols/hislip.py 59.53% 51 Missing and 19 partials ⚠️
pyvisa_py/tcpip.py 81.03% 3 Missing and 8 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #643      +/-   ##
==========================================
+ Coverage   48.74%   51.04%   +2.30%     
==========================================
  Files          35       35              
  Lines        5814     6114     +300     
  Branches      573      614      +41     
==========================================
+ Hits         2834     3121     +287     
+ Misses       2930     2919      -11     
- Partials       50       74      +24     
Flag Coverage Δ
unittests 51.04% <76.38%> (+2.30%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hb020

hb020 commented Sep 5, 2026

Copy link
Copy Markdown
Contributor Author

HiSLIP transforms into open-with-lock into open-and-then-lock.

In view of the problems with DMM6500, we should maybe also move VXI-11 to that method, just like NI-VISA does it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow locking on hislip

1 participant