gh-158546: Treat undecodable zipapp shebangs as absent - #158555
Open
rupayon123 wants to merge 1 commit into
Open
rupayon123 wants to merge 1 commit into
rupayon123 wants to merge 1 commit into
Conversation
|
The following commit authors need to sign the Contributor License Agreement: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Treat a shebang line that cannot be decoded using
zipapp.shebang_encodingas having no interpreter. Add a regression test for malformed shebang bytes and a Library NEWS entry.Fixes #158546
Testing
PYTHONPATH=Lib python3.15 -m unittest test.test_zipapp— 36 tests passed.UnicodeDecodeErroragainst the unmodified source before the fix.git diff --check— passed.The full CPython build/test matrix was not run; this change is limited to the pure-Python
zipappmodule and its tests.AI assistance was used to inspect the issue and code, draft the focused change and test, and review the diff. I reproduced the original behavior and ran the tests listed above.