gh-148773: Fix undefined behaviour in write() call#148774
Open
sideeffect42 wants to merge 2 commits intopython:mainfrom
Open
gh-148773: Fix undefined behaviour in write() call#148774sideeffect42 wants to merge 2 commits intopython:mainfrom
write() call#148774sideeffect42 wants to merge 2 commits intopython:mainfrom
Conversation
write()ing zero bytes to not a regular file (e.g. stdout) is undefined behaviour
and can generate a SIGHUP under certain circumstances, e.g. on AIX when running
with unbuffered stdout within sudo, screen, tmux:
$ sudo python3 -u -c 'print(""); print("foo")'
Hangup
Python's print() implementation in this case calls write() twice:
# truss python3 -u -c 'print("")'
[...]
kwrite(1, 0x08001000A001B910, 0) = 0
kwrite(1, "\n", 1) = 1
However, the first write() is undefined behaviour.
ssize_t write(int fildes, const void *buf, size_t nbyte);
The write() function shall attempt to write nbyte bytes from the buffer
pointed to by buf to the file associated with the open file descriptor,
fildes.
Before any action described below is taken, and if nbyte is zero and the
file is a regular file, the write() function may detect and return errors as
described below. In the absence of errors, or if error detection is not
performed, the write() function shall return zero and have no other results.
If nbyte is zero and the file is not a regular file, the results are
unspecified.
https://pubs.opengroup.org/onlinepubs/9699919799/functions/write.html
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
write()ing zero bytes to not a regular file (e.g. stdout) is undefined behaviour and can generate a SIGHUP under certain circumstances, e.g. on AIX when running with unbuffered stdout within sudo, screen, tmux:Python's
print()implementation in this case callswrite()twice:However, the first
write()is undefined behaviour.https://pubs.opengroup.org/onlinepubs/9699919799/functions/write.html