Draft
Conversation
hugovk
requested review from
AA-Turner,
FFY00 and
ericsnowcurrently
as code owners
| #if defined(MS_WINDOWS) && defined(HAVE_WINDOWS_CONSOLE_IO) | ||
| { | ||
| DWORD mode = 0; | ||
| HANDLE handle = GetStdHandle(STD_OUTPUT_HANDLE); |
Member
There was a problem hiding this comment.
Shouldn't this also consider stderr (or maybe it does? I don't know Windows quirks).
| PyMem_RawFree(buf); | ||
| } | ||
| else { | ||
| fprintf(f, usage_line, program); |
Member
There was a problem hiding this comment.
If PyMem_RawMalloc fails we will get the raw tags, no?
| return; | ||
| } | ||
| } | ||
| fprint_tagged(stdout, usage_envvars, 0); |
Member
There was a problem hiding this comment.
We still need formatting here?
Member
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
There was a problem hiding this comment.
What if the program path by accident contains {E}?
Member
Author
|
Updated to flip it: colour codes are now included in the help text (via macros to keep it tidier), and stripped out when not needed. So |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
python --help(and especially--help-all) is a monochrome wall of text. Similar to argparse help, let's add some colour to add structure and improve readability.Here's real screenshots of
--helpand termshot capture of--help-all:📚 Documentation preview 📚: https://cpython-previews--148767.org.readthedocs.build/