Fix AttributeError in log_uncached_deleted_message when channel is None#3499
Open
oliveman-au wants to merge 1 commit intopython-discord:mainfrom
Open
Fix AttributeError in log_uncached_deleted_message when channel is None#3499oliveman-au wants to merge 1 commit intopython-discord:mainfrom
AttributeError in log_uncached_deleted_message when channel is None#3499oliveman-au wants to merge 1 commit intopython-discord:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
self.bot.get_channel()can returnNoneif the channel isn't in the bot's cache, butchannel.categorywas being accessed immediately after with no None check, causing anAttributeError.This is particularly impactful because
log_uncached_deleted_messageis called for every deleted message that isn't in the cache, which on a large server happens constantly. Every one of those events would silently crash the handler instead of logging.Added an early return with a trace log if the channel can't be found, matching the pattern used elsewhere in the codebase.