feat: Allow keep_aspect_ratio flag for images in templates - #1893
Merged
andersonhc merged 3 commits intoJul 24, 2026
Conversation
Collaborator
|
@allcontributors please add @prateek-dagar for code |
|
I've put up a pull request to add @prateek-dagar! 🎉 |
andersonhc
approved these changes
Jul 24, 2026
andersonhc
left a comment
andersonhc
left a comment
Collaborator
There was a problem hiding this comment.
PR is ready to merge
Thanks for the contribution @prateek-dagar
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1118
This PR adds support for the
keep_aspect_ratioflag to image elements insidefpdf2templates (FlexTemplate). This allows templates to preserve the original aspect ratio of images without stretching or distortion.This work is based on the previous PR #1119 by @Clock-Speed, with additional fixes to the CSV parsing validation types, unit tests using
assert_pdf_equal, and documentation.Checklist:
docs/folderCHANGELOG.mdBy submitting this pull request, I confirm that my contribution is made under the terms of the GNU LGPL 3.0 license.