Repository navigation
Conversation
Put strings with markup characters into the caption, notes, coefficient labels and model heads, compile tex and typst, and check that the PDF text contains them. Cases that fail on main are strict xfails naming the cause, so each one has to be unmarked when its fix lands. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #135 (step 4).
What problem do you want to solve?
The compile tests run on one plain table, so they can't tell whether text with markup characters reaches the PDF intact. Text that changes silently still compiles: in LaTeX,
set {a}prints asset a, andp < 0.07prints asp ¡ 0.07.What this adds
tests/api/test_output_formats.pygets a round-trip matrix:% & _ # $ { ^ ~ < @ * [).p < 0.1, which made three LaTeX cases pass for the wrong reason.Results on
main: 46 pass, and 50 fail. The 50 are markedxfail(strict=True)with their cause:main% & _ # $ { ^ ~ <in all four parts (36)notes-percentis #99$ ~ @in all parts,*in caption and model head (14)I ran the matrix against the #99 and #122 branches. #99 turns exactly
notes-percentinto an unexpected pass, #122 does the same for exactly its 14 Typst cases, and neither causes a new failure. Because the markers are strict, whichever of those PRs merges after this one has to drop its markers. I'll push that change.Tests
tyare clean.pdflatexisn't installed, as the existing compile tests do.🤖 Generated with Claude Code