Conversation
aKlimau
force-pushed
the
add-pulp-exceptions
branch
8 times, most recently
from
5ebcc3a to
88bc331
Compare
| Stage, | ||
| ) | ||
|
|
||
| from pulp_python.app.exceptions import UnsupportedProtocolError |
There was a problem hiding this comment.
Why do we need this? I do not remember that is was reported by CI. It also looks like sth that should be in pulpcore.
There was a problem hiding this comment.
Can we replace UnsupportedProtocolError by SyncError?
aKlimau
force-pushed
the
add-pulp-exceptions
branch
5 times, most recently
from
02b7c62 to
d0d8812
Compare
aKlimau
force-pushed
the
add-pulp-exceptions
branch
from
d0d8812 to
005810f
Compare
aKlimau
force-pushed
the
add-pulp-exceptions
branch
3 times, most recently
from
510c96a to
10fe205
Compare
github-actions
Bot
removed
the
multi-commit
aKlimau
force-pushed
the
add-pulp-exceptions
branch
from
10fe205 to
c6d6bf7
Compare
| raise serializers.ValidationError(_("Invalid attestations: {}".format(e))) | ||
| return attestations | ||
|
|
||
| def handle_attestations(self, filename, sha256, attestations, offline=True): |
There was a problem hiding this comment.
This is called by PythonPackageContentUploadSerializer.validate, where it should raise a serializers.ValidationError
There was a problem hiding this comment.
It's still catching the same error as before the changes, I just renamed it from ValidationError to PydanticValidationError:
from pydantic import TypeAdapter, ValidationError as PydanticValidationError
Or am I getting smt wrong?
There was a problem hiding this comment.
handle_attestations now raises AttestationVerificationError instead of serializers.ValidationError
aKlimau
force-pushed
the
add-pulp-exceptions
branch
2 times, most recently
from
6ff02e1 to
d3c83d3
Compare
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
aKlimau
force-pushed
the
add-pulp-exceptions
branch
from
d3c83d3 to
6698572
Compare
2 participants
Assisted-by: Claude Sonnet 4.5 noreply@anthropic.com
📜 Checklist