Integration testing#269
Draft
limarkxx wants to merge 12 commits into
Draft
Conversation
Collaborator
|
ooooooooo! |
Collaborator
|
I love laravel as much as the next person (I daily drive it) but I wonder if adding Laravel here adds too much bloat to this extension's git repo. Shouldnt we test this extension against some base PHP files instead? Same applies with Slim or others. |
Contributor
Author
|
Maybe but it should at least be something at least slightly challenging for psalm to munch on. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds integration testing, with a sample multi-root workspace