Repository navigation
Proxy file fixes - #40
Merged
Merged
Conversation
The hash-based proxy file names were calculated only from the file path, so old proxies were reloaded when the proxied files changed. Now the file size and last modified timestamp is also taken into account to create a new proxy when a file changed.
The blocking stream had a race condition where the last read call got stuck forever when the end of the stream was signalled afterward.
When a proxy file wasn't fully written, e.g., due to errors or program termination, the incomplete file was used next time as if it were a complete file. Now proxy files are first written to a temporary file and promoted to the final proxy file only if complete.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses 3 issues in the context of proxy files: