Detect nested Keras Lambda layers#351
Open
dfgvaetyj3456356-hash wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The current Keras Lambda checks only inspect the first-level config.layers array. Keras model configs can contain nested model/layer configs, so a nested Lambda layer can be missed by ModelScan even though top-level Lambda layers are reported.
This is related to #340's nested config work, but narrower: #340 focuses on unsafe module references and preserves the existing top-level Lambda check. This PR specifically makes Lambda detection recursive and applies the same helper to H5 config parsing.
Testing
I could not run the broader ests/test_modelscan.py targets locally because the checkout is missing optional test dependencies such as dill and TensorFlow.