feature: count json objects with same value - #149
Open
parsa97 wants to merge 2 commits into
Open
Conversation
parsa97
force-pushed
the
add_count_for_json_values
branch
2 times, most recently
from
April 28, 2022 13:51
30d4492 to
39a9e37
Compare
SuperQ
reviewed
May 22, 2022
SuperQ
left a comment
SuperQ
left a comment
Contributor
There was a problem hiding this comment.
I like the idea, but I think we need to refactor some things first.
Contributor
|
This needs to be rebased. |
parsa97
force-pushed
the
add_count_for_json_values
branch
2 times, most recently
from
June 6, 2023 17:34
5c2d471 to
de7c4c7
Compare
Author
|
Hey Ben, PTAL |
|
@SuperQ @rustycl0ck please, take a look at this issue again |
SuperQ
requested changes
Sep 6, 2023
| labels: | ||
| environment: beta # static label | ||
| state: '{}' # dynamic label | ||
| mincount: 1 |
Contributor
There was a problem hiding this comment.
This mincount is not exactly obvious without reading the code. Let's document it in the example config. Also, for the config, maybe a nicer name.
Suggested change
| mincount: 1 | |
| # The minimum count of labels required to expose the metric for each label. Defaults to 1. | |
| minimumCount: 1 |
Author
There was a problem hiding this comment.
@SuperQ @rustycl0ck please, take a look at this issue again
parsa97
force-pushed
the
add_count_for_json_values
branch
from
September 6, 2023 18:05
de7c4c7 to
5632095
Compare
parsa97
force-pushed
the
add_count_for_json_values
branch
from
September 11, 2023 06:45
5632095 to
1b9f9f7
Compare
if we want to count json objects with same values we can use countbylabel type in the metric configuration Signed-off-by: Parsa <p.yousefi97@gmail.com>
parsa97
force-pushed
the
add_count_for_json_values
branch
2 times, most recently
from
September 11, 2023 13:38
447d93d to
f4d2d10
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if we want to count json objects with same values we can use
countbylabel type in the metric configuration