(feat) Introduce ManagementClusterClassifier CRD#637
Merged
Conversation
The existing Classifier evaluates rules against resources inside each managed cluster and applies labels based on what it finds there. This works well, but leaves a gap: there is no way to label managed clusters based on resources that live on the management cluster itself. A concrete example is an Internal Developer Platform backed by Crossplane. When a team orders an addon, a Crossplane Composite Resource is created on the management cluster. The platform needs to label the target cluster in response so that Sveltos can deploy the right addons. But sveltos-agent only sees the managed cluster, not the management cluster, so the existing Classifier cannot help here. This PR introduces two new CRDs to cover that gap. A **ManagementClusterClassifier** watches resources on the management cluster and runs a Lua function that receives the full set of matched resources and returns which managed clusters should be labeled. Because the evaluation happens entirely on the management cluster, no deployment to managed clusters is needed. A **ManagementClusterClassifierReport** tracks the label ownership state per classifier/cluster pair, enabling the same conflict detection the existing Classifier provides through the keymanager.
gianlucam76
force-pushed
the
mgmt-classifier
branch
from
6c9f511 to
1fcacd0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing Classifier evaluates rules against resources inside each managed cluster and applies labels based on what it finds there. This works well, but leaves a gap: there is no way to label managed clusters based on resources that live on the management cluster itself.
A concrete example is an Internal Developer Platform backed by Crossplane. When a team orders an addon, a Crossplane Composite Resource is created on the management cluster. The platform needs to label the target cluster in response so that Sveltos can deploy the right addons. But sveltos-agent only sees the managed cluster, not the management cluster, so the existing Classifier cannot help here.
This PR introduces two new CRDs to cover that gap. A ManagementClusterClassifier watches resources on the management cluster and runs a Lua function that receives the full set of matched resources and returns which managed clusters should be labeled. Because the evaluation happens entirely on the management cluster, no deployment to managed clusters is needed. A ManagementClusterClassifierReport tracks the label ownership state per classifier/cluster pair, enabling the same conflict detection the existing Classifier provides through the keymanager.