(feat) Guard against transient empty EventReports before deleting ClusterProfiles#498
Merged
Merged
Conversation
…sterProfiles A transient empty EventReport is a dangerous signal to act on immediately. Any condition that causes the agent to report zero matching resource, whether a brief informer inconsistency, a network hiccup, or an edge case not yet identified, would result in ClusterProfiles being deleted and then recreated, causing unnecessary churn in the managed cluster. event-manager now requires three consecutive collection cycles with zero matching resources before removing ClusterProfiles. On each of the first two observations it returns an error so the EventReport stays unprocessed and is picked up again on the next poll. On the third consecutive observation it proceeds with the removal. The safeguard does not apply when the EventReport itself is being deleted, since in that case removal is intentional and should happen immediately. When matching resources are present the counter resets, so the threshold is always three consecutive observations rather than four cumulative ones.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A transient empty EventReport is a dangerous signal to act on immediately. Any condition that causes the agent to report zero matching resource, whether a brief informer inconsistency, a network hiccup, or an edge case not yet identified, would result in ClusterProfiles being deleted and then recreated, causing unnecessary churn in the managed cluster.
event-manager now requires three consecutive collection cycles with zero matching resources before removing ClusterProfiles.
On each of the first two observations it returns an error so the EventReport stays unprocessed and is picked up again on the next poll. On the third consecutive observation it proceeds with the removal.
The safeguard does not apply when the EventReport itself is being deleted, since in that case removal is intentional and should happen immediately. When matching resources are present the counter resets, so the threshold is always three consecutive observations rather than four cumulative ones.