migrate aurora v2 to v4 + bump pd deps#983
Conversation
WalkthroughThe PR migrates the codebase to use ChangesAurora v4 Migration
🎯 3 (Moderate) | ⏱️ ~20 minutes
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
internal/runner/runner.go (1)
444-447: ⚡ Quick winSilent error handling may hide input processing failures.
When iteration encounters an error, the goroutine returns silently without logging. This could leave users unaware that their input was only partially processed (e.g., file read errors, permission issues mid-stream). Consider logging the error before returning to aid debugging.
Additionally, this behavior is inconsistent with
linesInFileinutil.gowhich propagates errors to callers.Proposed fix
for line, err := range it { if err != nil { + gologger.Debug().Msgf("error reading input: %v", err) return } ch <- line }🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@internal/runner/runner.go` around lines 444 - 447, The goroutine iterating with the iterator variable `it` currently returns silently on error (in the loop: `for line, err := range it { if err != nil { return } }`), which hides failures; change this to surface the error—log the error via the same logger used in this package (or `processLogger`/contextual logger) before returning and/or send the error to the caller (e.g., return it on an error channel or set an error variable) to match the behavior of `linesInFile` in `util.go`; update the loop in the function containing `for line, err := range it` to log `err` with clear context and ensure callers can observe the failure (propagate the error instead of silently returning).
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@internal/runner/runner.go`:
- Around line 444-447: The goroutine iterating with the iterator variable `it`
currently returns silently on error (in the loop: `for line, err := range it {
if err != nil { return } }`), which hides failures; change this to surface the
error—log the error via the same logger used in this package (or
`processLogger`/contextual logger) before returning and/or send the error to the
caller (e.g., return it on an error channel or set an error variable) to match
the behavior of `linesInFile` in `util.go`; update the loop in the function
containing `for line, err := range it` to log `err` with clear context and
ensure callers can observe the failure (propagate the error instead of silently
returning).
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 3a08c8c3-43bf-4625-a047-94501ff1391d
📒 Files selected for processing (2)
internal/runner/runner.gointernal/runner/util.go
1 participant
Migrates dnsx from
logrusorgru/aurorav2 to v4 (new*Aurorastruct +New(WithColors(...))constructor) and bumps the projectdiscovery group of deps to current versions. Supersedes Dependabot PR #981 which couldn't merge on its own because the dep bump requires this aurora migration.Summary by CodeRabbit