Repository navigation
Close out the node-addressing project - #391
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: willbot <w.a.madden+machine@gmail.com> Signed-off-by: Will Madden <madden@prisma.io>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: willbot <w.a.madden+machine@gmail.com> Signed-off-by: Will Madden <madden@prisma.io>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: willbot <w.a.madden+machine@gmail.com> Signed-off-by: Will Madden <madden@prisma.io>
|
✅ Gizmo reviewed 1a67e0a — posted 1 inline comment(s) this pass. Open findings: 🟡 1 minor Change walkthroughOverviewThis PR ends the node-addressing project: it documents the last user-facing feature (addresses as subjects of platform commands), records the project's retro lessons, and deletes the Docs and skillThe bulk of the change is two mirrored paragraphs in docs/guides/deploying.md and skills/prisma-composer-core-concepts/SKILL.md describing
|
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: willbot <w.a.madden+machine@gmail.com> Signed-off-by: Will Madden <madden@prisma.io>
Brings in ADR-0059 (environment, not stage), the stage-to-environment rename (#390), the node-addressing close-out (#391), v0.35.0 (#389) and prisma dev --environment (#392). The secrets behaviour follows each environment: the dev preflight keeps its fingerprint key in the environment folder, and deletes a leftover secrets.json both there and in the pre-environment folder. Moving pre-environment state into dev no longer moves secrets.json; it deletes it. Tests pass the environment, and our docs say environment where main renamed stage and environment variables where they mean variables. Signed-off-by: willbot <w.a.madden+machine@gmail.com> Signed-off-by: Will Madden <madden@prisma.io> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The node-addressing project is finished. This PR closes it out: it documents the last user-facing piece, records the project's lessons, and deletes the project's planning folder.
What the project delivered
One string, a node's full address (
shop.catalog.db), now names any deployed part of a Composer app everywhere:logicalIds, topology, resource IDs andCOMPOSER_keys use the full address. Existing apps migrate on their next deploy without losing data.prisma.config.ts(Set deploy's entry file in prisma.config.ts, not on the command line #387, Composer 0.35.0).prisma deploy list(Add prisma deploy list: show every deployed node of a stage with its address and platform ID #388, Composer 0.35.0), mounted in theprismaCLI by Move to Composer 0.35.0 and mount prisma deploy list prisma-cli#371.Done conditions
deploy listlists every node;service logs @<stage>:<address>reaches the right serviceprisma branch deleteremoves a running stageproject deleteand check withproject list, using only the docsWhat changes in
.drive/.drive/projects/node-addressing/. Every file was transient: the spec, plan, design notes (now in ADR-0057, ADR-0050's amendments and prisma-cli's command principles), the spike's findings, QA records and reviews. Their evidence is in each slice's PR. No other file links to the folder..drive/PLAN.md. A new.drive/PROJECT.mdsays where long-lived docs go at close-out..drive/deferred.mdrecords the canceled stage removal. It also defers removing CI'sdeleteProjectDeepworkaround, because that is CI cleanup, not addressing. The deferreddeploy deleteentry no longer relies onbranch delete.Agent: victoria-52
🤖 Generated with Claude Code