Skip to content

Close out the node-addressing project - #391

Merged
wmadden merged 4 commits into
mainfrom
drive/close-node-addressing
Oct 28, 2026
Merged

wmadden merged 4 commits into
mainfrom
drive/close-node-addressing

Conversation

@wmadden-electric

@wmadden-electric wmadden-electric commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor
prisma service logs @pr-42:storefront-auth.auth.service

The node-addressing project is finished. This PR closes it out: it documents the last user-facing piece, records the project's lessons, and deletes the project's planning folder.

What the project delivered

One string, a node's full address (shop.catalog.db), now names any deployed part of a Composer app everywhere:

Done conditions

Condition Result
An app deployed with the old release and redeployed with the new one keeps its rows, objects, secrets and RPC keys Met. A1's QA on the real platform; #384 has the evidence.
A new stage deploys from scratch Met once the platform fixed bucket copying on new Branches (prisma/pdp-control-plane#5823). The first deploy of an app with a bucket to a new stage was then checked against production.
The asks app upgrades in production with data intact Met (prisma/asks#239).
deploy list lists every node; service logs @<stage>:<address> reaches the right service Met (#388 QA; prisma/prisma-cli#373 end-to-end tests).
prisma branch delete removes a running stage Canceled. Stage removal isn't about addresses, and the platform team has recorded a decision against a cascading Branch delete.
An agent can remove an app with project delete and check with project list, using only the docs Met in substance: the guides and skill describe it, and QA ran exactly those commands while services were running. No agent was ever given only the docs and asked to do it.
Design records and docs describe the new address format only Met (ADR-0057 and its amendments in #384).

What changes in .drive/

  • Deleted: .drive/projects/node-addressing/. Every file was transient: the spec, plan, design notes (now in ADR-0057, ADR-0050's amendments and prisma-cli's command principles), the spike's findings, QA records and reviews. Their evidence is in each slice's PR. No other file links to the folder.
  • Final retro (recorded in the folder before deleting it): stage removal got into the plan because the design discussion started from teardown, and nobody checked each slice against the project's purpose. And the cascading Branch delete was planned without reading the platform team's decision against it. Both lessons go into a new .drive/PLAN.md. A new .drive/PROJECT.md says where long-lived docs go at close-out.
  • Deferred: .drive/deferred.md records the canceled stage removal. It also defers removing CI's deleteProjectDeep workaround, because that is CI cleanup, not addressing. The deferred deploy delete entry no longer relies on branch delete.

Agent: victoria-52

🤖 Generated with Claude Code

wmadden-electric and others added 3 commits October 28, 2026 10:26
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: willbot <w.a.madden+machine@gmail.com>
Signed-off-by: Will Madden <madden@prisma.io>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: willbot <w.a.madden+machine@gmail.com>
Signed-off-by: Will Madden <madden@prisma.io>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: willbot <w.a.madden+machine@gmail.com>
Signed-off-by: Will Madden <madden@prisma.io>
@prisma-gizmo

prisma-gizmo Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

✅ Gizmo reviewed 1a67e0a — posted 1 inline comment(s) this pass.

Open findings: 🟡 1 minor

Change walkthrough

Overview

This PR ends the node-addressing project: it documents the last user-facing feature (addresses as subjects of platform commands), records the project's retro lessons, and deletes the .drive/projects/node-addressing/ planning folder.

Docs and skill

The bulk of the change is two mirrored paragraphs in docs/guides/deploying.md and skills/prisma-composer-core-concepts/SKILL.md describing @<environment>:<address> subjects for platform commands (the resolution itself ships in prisma/prisma-cli#373). Both follow the files' established patterns — the guide adds a ### subsection after the deploy list output that produces the addresses, the skill a bold-lead entry beside its neighbors — and both pin the required CLI release (newer than 8.0.0-rc.28) the same way the deploy list section pins 8.0.0-rc.26. Terminology matches ADR-0059 ("environment", never "stage") and the production default matches deploy list's behavior.

.drive/ records

  • PLAN.md turns the retro into two dated planning checks (slices must serve the project's purpose; read the owning team's decision records before planning a slice in their repo). It sits at the .drive/ root as a peer of CODE-REVIEW.md, matching how that repo keeps cross-project guidance.
  • PROJECT.md records the close-out conventions: long-lived docs go to ADRs, glossary, guides and skills; everything under .drive/projects/<project>/ is transient; close-out PRs reference no Linear Project.
  • deferred.md gains a "deferred at project close" section recording the canceled cascading Branch delete / prisma branch delete and the deferred CI cleanup of deleteProjectDeep (verified to exist in scripts/ci-cleanup-utils.ts with the described 409 retry). The older deploy delete entry is rewritten to stop citing branch delete as its equivalent — accurate, since destroying a named stage also deletes its Branch.

Folder deletion

The whole .drive/projects/node-addressing/ tree is removed. I confirmed nothing in the tree links to the deleted folder — the remaining "node-addressing" mentions are prose references to the project name in PLAN.md and deferred.md, which is intentional.

@coderabbitai

coderabbitai Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: d7d5bd56-c8ff-4c3f-8bd9-174967611617
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@prisma-gizmo prisma-gizmo Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New findings: 🟡 1 minor · trace

Comment thread docs/guides/deploying.md Resolved
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: willbot <w.a.madden+machine@gmail.com>
Signed-off-by: Will Madden <madden@prisma.io>
@wmadden
wmadden enabled auto-merge (squash) October 28, 2026 09:36
@wmadden
wmadden merged commit 05f4234 into main Oct 28, 2026
15 of 17 checks passed
@wmadden
wmadden deleted the drive/close-node-addressing branch October 28, 2026 09:45
wmadden-electric added a commit that referenced this pull request Oct 28, 2026
Brings in ADR-0059 (environment, not stage), the stage-to-environment rename (#390), the node-addressing close-out (#391), v0.35.0 (#389) and prisma dev --environment (#392).

The secrets behaviour follows each environment: the dev preflight keeps its fingerprint key in the environment folder, and deletes a leftover secrets.json both there and in the pre-environment folder. Moving pre-environment state into dev no longer moves secrets.json; it deletes it. Tests pass the environment, and our docs say environment where main renamed stage and environment variables where they mean variables.

Signed-off-by: willbot <w.a.madden+machine@gmail.com>
Signed-off-by: Will Madden <madden@prisma.io>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants