Skip to content

fix: bump phoenix 1.6.17 and close leftover code-scanning alerts - #1513

Merged
zreigz merged 5 commits into
masterfrom
fix-remaining-code-scanning
Sep 15, 2026
Merged

zreigz merged 5 commits into
masterfrom
fix-remaining-code-scanning

Conversation

@zreigz

@zreigz zreigz commented Sep 14, 2026

Copy link
Copy Markdown
Member

Phoenix 1.6.17 patches the HIGH channel-join DoS. Defer ESM-incompatible decode-uri-component 0.2.2 and react-router v7 MEDIUMs, and retry tool downloads so image scans can run.

Test Plan

Checklist

  • If required, I have updated the Plural documentation accordingly.
  • I have added tests to cover my changes.
  • I have added a meaningful title and summary to convey the impact of this PR to a user.
  • I have added relevant labels to this PR to help with categorization for release notes.

Phoenix 1.6.17 patches the HIGH channel-join DoS. Defer ESM-incompatible decode-uri-component 0.2.2 and react-router v7 MEDIUMs, and retry tool downloads so image scans can run.
@zreigz zreigz added the dependencies Pull requests that update a dependency file label Sep 14, 2026
@greptile-apps

greptile-apps Bot commented Sep 14, 2026

Copy link
Copy Markdown

RetriggerConfidence Score: 4/5

The PR should not merge until retried archive downloads are made restart-safe; the overbroad react-router scan exceptions should also be narrowed.

Findings

  1. P1 Retries Corrupt Streamed Archives
  2. P2 React Router Ignores Too Broadly

Summary

  • Phoenix is consistently pinned to 1.6.17 across the umbrella and application manifests.
  • Tool downloads now request HTTP failure handling and retries, but streamed retries cannot reliably recover interrupted archives.
  • New vulnerability deferrals cover decode-uri-component and react-router; the react-router selectors are broader than their stated version-specific rationale.

Reviews (1) · Last reviewed commit: "fix: bump phoenix 1.6.17 and close lefto..."

Comment thread Dockerfile Outdated
Comment thread .trivyignore.yaml Outdated
CLI image builds were failing on GitHub 504s because curl | tar hid curl's exit code. Download Helm, the CLI, and Trivy to files with longer retries, and pull Helm from GitHub releases instead of get.helm.sh.
Keep the MEDIUM exceptions from applying after a later upgrade.
Helm GitHub releases only ship signatures, so the tarball URL 404s. Use the previous get.helm.sh plus curl|tar flow that already built images.
The Helm, CLI, and Trivy URLs are correct. CI was unpacking 92-byte GitHub error bodies because curl -L succeeded without -f. Download to files, require >1MB, then extract.
@zreigz
zreigz merged commit 94d3d7b into master Sep 15, 2026
17 checks passed
@zreigz
zreigz deleted the fix-remaining-code-scanning branch September 15, 2026 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants